Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Target initializer to use InfoPlist.default as default value #3644

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

hisaac
Copy link
Collaborator

@hisaac hisaac commented Nov 7, 2021

Resolves https://github.com/tuist/tuist/discussions/3635

Short description 📝

This change updates Target's initializer to use InfoPlist.default as the default value for the infoPlist argument. Many of the other arguments have default values, so this seems like an appropriate change.

Checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase.
  • The changes have been tested following the documented guidelines. (Currently running in CI)
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.
  • In case the PR introduces changes that affect how the cache artifact is generated starting from the TuistGraph.Target, the Constants.cacheVersion has been updated.

@hisaac hisaac requested review from a team, RomainBoulay and andreacipriani and removed request for a team November 7, 2021 17:15
@hisaac hisaac requested a review from a team November 7, 2021 17:18
Copy link
Collaborator

@danieleformichelli danieleformichelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also update the documentation in projects/docs/docs/manifests/project.md to set Required to No? 🙏

@hisaac
Copy link
Collaborator Author

hisaac commented Nov 7, 2021

Definitely, I appreciate the guidance.

@pepicrft pepicrft merged commit 6118edd into main Nov 8, 2021
@pepicrft pepicrft deleted the update-default-initializer-value branch November 8, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants