-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Infinite recursion and Incorrect deprecation notice in PathRunnable #889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching this @georgenavarro - I missed this during review 🙈
@@ -87,7 +87,6 @@ public extension XCScheme { | |||
|
|||
// MARK: - Init | |||
|
|||
@available(*, deprecated, message: "Use the init() that consolidates pathRunnable and runnable into a single parameter.") | |||
public init(runnable: Runnable?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this init
has both runnable
and pathRunnable
:/
For the deprecation the following is needed:
// Consolidated init
init(
runnable: Runnable?,
// ....
)
@available(*, deprecated, message: "Use the init() that consolidates pathRunnable and runnable into a single parameter.")
init(
runnable: Runnable?,
// ....
pathRunnable: PathRunnable?, // <-- without a default `= nil`,
// ....
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this, I'll prepare the change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @georgenavarro
The installation of Swift in the Linux environment is failing. Since I checked that test and build passes locally, I'll go ahead with the merge and investigate that issue separately. |
Short description 📝
A recent pull request that modified
LaunchAction
introduced two issues into the class:pathRunnable
property causes infinite recursionSolution 📦
pathRunnable
setter by having it modify the backingrunnable
property instead of having it accidentally call itself.PathRunnable
and removed it from the init that accepts a genericRunnable
.