-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configurable user collection #27
Conversation
@@ -23,6 +23,8 @@ bld/ | |||
|
|||
# Visual Studio 2015 cache/options directory | |||
.vs/ | |||
# Visual Studio Code / options directory | |||
.vscode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be ignored. This folder is from VS Code to hold workspace specific settings.
@@ -35,7 +35,7 @@ static MongoUserStore() | |||
MongoConfig.EnsureConfigured(); | |||
} | |||
|
|||
public MongoUserStore(IMongoDatabase database, ILoggerFactory loggerFactory) | |||
public MongoUserStore(IMongoDatabase database, ILoggerFactory loggerFactory, string userCollectionName = "users") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you go with constructor overload instead of optional parameters?
see http://haacked.com/archive/2010/08/10/versioning-issues-with-optional-arguments.aspx/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course, nice article :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SorenZ Thanks for the PR 😄 Seems generally good, there are couple minor things to change. If you can change them, I will get this in 😄
@tugberkugurlu I hope the changes accepted. |
@SorenZ great, thanks a lot! |
allow users to pass an optional user's collection name to
MongoUserStore
constructor. #26