Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1400

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix #1400

merged 1 commit into from
Dec 21, 2023

Conversation

tubone24
Copy link
Owner

PR title

Status

READY/IN DEVELOPMENT/HOLD

Description

A few sentences describing the overall goals of the pull request's commits.

Related PRs

List related PRs against other branches:

branch PR
other_pr_master link
other_pr_develop link

Todos

  • Tests
  • e2e Tests
  • Storybook
  • Documentation

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

git pull --prune
git checkout <feature_branch>
yarn test

Preview Deploy

Describe the URL of the Preview Deploy.

link

Impacted Areas in Application

List general components of the application that this PR will affect:

  • aaa
  • bbb

Screenshot

Replace FIXME_BRANCH_NAME, FIXME_PR_NUMBER in the URL below with this branch name and PR number.

Desktop

Width 1200px

Desktop Home

Mobile

Width 400px

mobile home

Copy link
Contributor

depcheck Result

List up libraries that are defined in dependencies and devDependencies in package.json but not used in your codes.

Unused dependencies
- @popperjs/core
- @sentry/react
- @typescript-eslint/eslint-plugin
- babel-loader
- babel-polyfill
- classnames
- flexboxgrid
- gatsby-legacy-polyfills
- gatsby-plugin-flexsearch
- gatsby-plugin-twitter
- gatsby-react-router-scroll
- html-minifier
- intersection-observer
- md5
- preact
- preact-render-to-string
- react-body-classname
- react-dom
- rimraf
- sass
- typescript
Unused devdependencies
- @babel/core
- @babel/preset-typescript
- @storybook/addon-a11y
- @storybook/addon-controls
- @storybook/addon-essentials
- @storybook/addon-info
- @storybook/addon-interactions
- @storybook/addon-knobs
- @storybook/addon-links
- @storybook/addon-storysource
- @storybook/addon-viewport
- @storybook/builder-webpack5
- @storybook/manager-webpack5
- @textlint-rule/textlint-rule-no-duplicate-abbr
- @types/jest
- @types/react-test-renderer
- @types/responselike
- axe-core
- @babel/eslint-parser
- babel-plugin-transform-runtime
- core-js
- cross-env
- css-loader
- eslint
- eslint-config-airbnb
- eslint-import-resolver-webpack
- eslint-plugin-import
- eslint-plugin-jsx-a11y
- eslint-plugin-react
- gh-pages
- husky
- identity-obj-proxy
- jest
- jest-environment-jsdom
- markdownlint-cli2
- memlab
- netlify-cli
- netlify-lambda
- nyc
- prettier
- react-test-renderer
- sass-loader
- start-server-and-test
- stylelint
- stylelint-config-recess-order
- stylelint-config-recommended-scss
- stylelint-config-standard
- stylelint-scss
- textlint
- textlint-filter-rule-allowlist
- textlint-filter-rule-comments
- textlint-rule-aws-spellcheck
- textlint-rule-ja-no-inappropriate-words
- textlint-rule-no-mixed-zenkaku-and-hankaku-alphabet
- textlint-rule-no-start-duplicated-conjunction
- textlint-rule-preset-smarthr
- textlint-rule-prh
- textlint-rule-terminology
- ts-jest
- yaml-lint
Missing
- colors
  - /github/workspace/src/styles/_hover.scss

- @algolia/transporter
  - /github/workspace/src/components/SearchBox/index.tsx

- @algolia/client-search
  - /github/workspace/src/components/SearchBox/index.tsx

- qs
  - /github/workspace/scripts/benchmark.js

- https
  - /github/workspace/scripts/uploadScreenShot.ts

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7290547327

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.602%

Totals Coverage Status
Change from base Build 7286238169: 0.0%
Covered Lines: 250
Relevant Lines: 280

💛 - Coveralls

github-actions bot pushed a commit that referenced this pull request Dec 21, 2023
Copy link
Contributor

Deploy Preview

Deploy path: /home/runner/work/blog/blog/public
Functions path: /home/runner/work/blog/blog/functions/src
Configuration path: /home/runner/work/blog/blog/netlify.toml
Deploying to draft URL...

Logs: https://app.netlify.com/sites/pensive-lamport-5822d2/deploys/65846454bd2a3813fcdf115d
Website Draft URL: https://65846454bd2a3813fcdf115d--pensive-lamport-5822d2.netlify.app

If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag.
netlify deploy --prod

Copy link
Contributor

Copy link
Contributor

Memlab leaks report

page-load [7.3MB] (baseline) [s1] > action-on-page [8.9MB] (target) [s2] > revert [9.1MB] (final) [s3]  
------2 clusters------

--Similar leaks in this run: 1557--
--Retained size of leaked objects: 195.1KB--
[<synthetic>] (synthetic) @1 [10.3MB]
  --4 (shortcut)--->  [Window / https://blog.tubone-project24.xyz] (object) @6217 [62.1KB]
  --setTimeout (property)--->  [<closure>] (closure) @43603 [72 bytes]
  --context (internal)--->  [<function scope>] (object) @239439 [20 bytes]
  --previous (internal)--->  [<function scope>] (object) @77677 [35.5KB]
  --n (variable)--->  [t] (closure) @108745 [1.3KB]
  --context (internal)--->  [<function scope>] (object) @237183 [48KB]
  --n (variable)--->  [Object] (object) @112481 [47.9KB]
  --449 (element)--->  [Object] (object) @112921 [24 bytes]
  --exports (property)--->  [r] (closure) @197167 [2.6KB]
  --hasData (property)--->  [<closure>] (closure) @133655 [76 bytes]
  --context (internal)--->  [<function scope>] (object) @133649 [1.4KB]
  --e (variable)--->  [Object] (object) @264905 [1KB]
  --2 (element)--->  [Object] (object) @402503 [76 bytes]
  --aaAutocomplete (property)--->  [f] (object) @395295 [348 bytes]
  --$node (property)--->  [q] (object) @383397 [188 bytes]
  --0 (element)--->  [Detached HTMLSpanElement] (native) @322419 [912 bytes]
  --7 (element)--->  [Detached HTMLDivElement] (native) @322925 [6KB]
  --7 (element)--->  [Detached HTMLDivElement] (native) @322799 [680 bytes]
  --5 (element)--->  [Detached HTMLAnchorElement] (native) @322797 [5.3KB]
  --9 (element)--->  [Detached HTMLAnchorElement] (native) @322785 [2.6KB]
  --12 (element)--->  [Detached HTMLParagraphElement] (native) @322777 [912 bytes]
  --9 (element)--->  [Detached HTMLAnchorElement] (native) @322773 [2.8KB]
  --6 (element)--->  [Detached HTMLSpanElement] (native) @322771 [1.5KB]
  --5 (element)--->  [Detached HTMLSpanElement] (native) @322769 [680 bytes]
  --7 (element)--->  [Detached InternalNode] (native) @58578 [240 bytes]
  --1 (element)--->  [Detached InternalNode] (native) @38860 [184 bytes]
  --1 (element)--->  [Detached DOMTokenList] (native) @37188 [56 bytes]

--Similar leaks in this run: 539--
--Retained size of leaked objects: 75.1KB--
[<synthetic>] (synthetic) @1 [10.3MB]
  --4 (shortcut)--->  [Window / https://blog.tubone-project24.xyz] (object) @6217 [62.1KB]
  --___replace (property)--->  [<closure>] (closure) @43943 [76 bytes]
  --context (internal)--->  [<function scope>] (object) @250029 [724 bytes]
  --a (variable)--->  [Module] (object) @107825 [6.1KB]
  --get version (property)--->  [version] (closure) @107491 [76 bytes]
  --context (internal)--->  [<function scope>] (object) @107153 [6.3KB]
  --Qn (variable)--->  [y] (object) @423015 [368 bytes]
  --props (property)--->  [Object] (object) @439935 [28 bytes]
  --children (property)--->  [Object] (object) @436669 [296 bytes]
  --props (property)--->  [Object] (object) @436653 [56 bytes]
  --children (property)--->  [Object] (object) @436657 [1.2KB]
  --__ (property)--->  [Object] (object) @468241 [1.1KB]
  --__ (property)--->  [Object] (object) @468225 [940 bytes]
  --__ (property)--->  [Object] (object) @468231 [736 bytes]
  --__d (property)--->  [Detached HTMLDivElement] (native) @322841 [736 bytes]
  --5 (element)--->  [Detached HTMLDivElement] (native) @322839 [680 bytes]
  --5 (element)--->  [Detached HTMLDivElement] (native) @322837 [680 bytes]
  --5 (element)--->  [Detached HTMLDivElement] (native) @322835 [10.6KB]
  --5 (element)--->  [Detached HTMLDivElement] (native) @322831 [9.4KB]
  --6 (element)--->  [Detached HTMLDivElement] (native) @322823 [7.5KB]
  --5 (element)--->  [Detached HTMLDivElement] (native) @322821 [5.9KB]
  --5 (element)--->  [Detached HTMLPictureElement] (native) @322819 [4.3KB]
  --5 (element)--->  [Detached HTMLSourceElement] (native) @322817 [1.8KB]
  --10 (element)--->  [Detached InternalNode] (native) @30642 [416 bytes]
  --1 (element)--->  [Detached InternalNode] (native) @30634 [360 bytes]
  --1 (element)--->  [Detached DOMTokenList] (native) @30636 [56 bytes]

Copy link
Contributor

Storybook Preview

Deploy path: /home/runner/work/blog/blog/storybook-static
Functions path: /home/runner/work/blog/blog/functions/src
Configuration path: /home/runner/work/blog/blog/netlify.toml
Deploying to draft URL...

Logs: https://app.netlify.com/sites/blog-storybook/deploys/65846499b8d63514fbd203bf
Website Draft URL: https://65846499b8d63514fbd203bf--blog-storybook.netlify.app

If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag.
netlify deploy --prod

github-actions bot pushed a commit that referenced this pull request Dec 21, 2023
github-actions bot pushed a commit that referenced this pull request Dec 21, 2023
github-actions bot pushed a commit that referenced this pull request Dec 21, 2023
github-actions bot pushed a commit that referenced this pull request Dec 21, 2023
Copy link
Contributor

Lighthouse Score

Desktop

performance: 81
accessibility: 100
best-practices: 100
seo: 92
pwa: 100

Mobile

performance: 72
accessibility: 100
best-practices: 95
seo: 93
pwa: 100

@tubone24 tubone24 merged commit 1526b1b into master Dec 21, 2023
34 checks passed
@tubone24 tubone24 deleted the ddd branch December 21, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants