Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddd #1398

Merged
merged 1 commit into from
Dec 19, 2023
Merged

ddd #1398

merged 1 commit into from
Dec 19, 2023

Conversation

tubone24
Copy link
Owner

PR title

Status

READY/IN DEVELOPMENT/HOLD

Description

A few sentences describing the overall goals of the pull request's commits.

Related PRs

List related PRs against other branches:

branch PR
other_pr_master link
other_pr_develop link

Todos

  • Tests
  • e2e Tests
  • Storybook
  • Documentation

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

git pull --prune
git checkout <feature_branch>
yarn test

Preview Deploy

Describe the URL of the Preview Deploy.

link

Impacted Areas in Application

List general components of the application that this PR will affect:

  • aaa
  • bbb

Screenshot

Replace FIXME_BRANCH_NAME, FIXME_PR_NUMBER in the URL below with this branch name and PR number.

Desktop

Width 1200px

Desktop Home

Mobile

Width 400px

mobile home

@github-actions GitHub Actions
Copy link
Contributor

depcheck Result

List up libraries that are defined in dependencies and devDependencies in package.json but not used in your codes.

Unused dependencies 
- @popperjs/core
- @sentry/react
- @typescript-eslint/eslint-plugin
- babel-loader
- babel-polyfill
- classnames
- flexboxgrid
- gatsby-legacy-polyfills
- gatsby-plugin-flexsearch
- gatsby-plugin-twitter
- gatsby-react-router-scroll
- html-minifier
- intersection-observer
- md5
- preact
- preact-render-to-string
- react-body-classname
- react-dom
- rimraf
- sass
- typescript
Unused devdependencies 
- @babel/core
- @babel/preset-typescript
- @storybook/addon-a11y
- @storybook/addon-controls
- @storybook/addon-essentials
- @storybook/addon-info
- @storybook/addon-interactions
- @storybook/addon-knobs
- @storybook/addon-links
- @storybook/addon-storysource
- @storybook/addon-viewport
- @storybook/builder-webpack5
- @storybook/manager-webpack5
- @textlint-rule/textlint-rule-no-duplicate-abbr
- @types/jest
- @types/react-test-renderer
- @types/responselike
- axe-core
- @babel/eslint-parser
- babel-plugin-transform-runtime
- core-js
- cross-env
- css-loader
- eslint
- eslint-config-airbnb
- eslint-import-resolver-webpack
- eslint-plugin-import
- eslint-plugin-jsx-a11y
- eslint-plugin-react
- gh-pages
- husky
- identity-obj-proxy
- jest
- jest-environment-jsdom
- markdownlint-cli2
- memlab
- netlify-cli
- netlify-lambda
- nyc
- prettier
- react-test-renderer
- sass-loader
- start-server-and-test
- stylelint
- stylelint-config-recess-order
- stylelint-config-recommended-scss
- stylelint-config-standard
- stylelint-scss
- textlint
- textlint-filter-rule-allowlist
- textlint-filter-rule-comments
- textlint-rule-aws-spellcheck
- textlint-rule-ja-no-inappropriate-words
- textlint-rule-no-mixed-zenkaku-and-hankaku-alphabet
- textlint-rule-no-start-duplicated-conjunction
- textlint-rule-preset-smarthr
- textlint-rule-prh
- textlint-rule-terminology
- ts-jest
- yaml-lint
Missing 
- colors
  - /github/workspace/src/styles/_hover.scss

- @algolia/transporter
  - /github/workspace/src/components/SearchBox/index.tsx

- @algolia/client-search
  - /github/workspace/src/components/SearchBox/index.tsx

- qs
  - /github/workspace/scripts/benchmark.js

- https
  - /github/workspace/scripts/uploadScreenShot.ts

@github-actions github-actions bot temporarily deployed to development-storybook December 19, 2023 15:17 Inactive
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7263815106

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.602%
Totals Coverage Status
Change from base Build 7242890409: 0.0%
Covered Lines: 250
Relevant Lines: 280
💛 - Coveralls

@github-actions GitHub Actions
Copy link
Contributor

Memlab leaks report

page-load [7.2MB] (baseline) [s1] > action-on-page [8.9MB] (target) [s2] > revert [9.1MB] (final) [s3]  
------2 clusters------

--Similar leaks in this run: 1608--
--Retained size of leaked objects: 166.3KB--
[<synthetic>] (synthetic) @1 [10.3MB]
  --6 (shortcut)--->  [Window / https://blog.tubone-project24.xyz] (object) @6227 [62KB]
  --setTimeout (property)--->  [<closure>] (closure) @43037 [72 bytes]
  --context (internal)--->  [<function scope>] (object) @255551 [20 bytes]
  --previous (internal)--->  [<function scope>] (object) @104621 [35KB]
  --n (variable)--->  [t] (closure) @148847 [1.3KB]
  --context (internal)--->  [<function scope>] (object) @251497 [42.7KB]
  --n (variable)--->  [Object] (object) @251503 [42.6KB]
  --449 (element)--->  [Object] (object) @110967 [24 bytes]
  --exports (property)--->  [r] (closure) @110973 [2.6KB]
  --hasData (property)--->  [<closure>] (closure) @132649 [76 bytes]
  --context (internal)--->  [<function scope>] (object) @148815 [1.4KB]
  --e (variable)--->  [Object] (object) @148817 [1KB]
  --2 (element)--->  [Object] (object) @328131 [76 bytes]
  --aaAutocomplete (property)--->  [f] (object) @361831 [348 bytes]
  --$node (property)--->  [q] (object) @400395 [188 bytes]
  --0 (element)--->  [Detached HTMLSpanElement] (native) @322223 [616 bytes]
  --7 (element)--->  [Detached HTMLDivElement] (native) @320431 [5.7KB]
  --7 (element)--->  [Detached HTMLDivElement] (native) @320963 [384 bytes]
  --6 (element)--->  [Detached HTMLDivElement] (native) @320459 [384 bytes]
  --6 (element)--->  [Detached HTMLAnchorElement] (native) @320627 [2.3KB]
  --11 (element)--->  [Detached HTMLAnchorElement] (native) @320641 [2.3KB]
  --11 (element)--->  [Detached HTMLAnchorElement] (native) @320655 [2.3KB]
  --11 (element)--->  [Detached HTMLAnchorElement] (native) @320669 [2.3KB]
  --11 (element)--->  [Detached HTMLAnchorElement] (native) @320683 [2.3KB]
  --11 (element)--->  [Detached HTMLAnchorElement] (native) @320697 [2.3KB]
  --11 (element)--->  [Detached HTMLAnchorElement] (native) @320711 [2.3KB]
  --11 (element)--->  [Detached HTMLAnchorElement] (native) @320725 [2.3KB]
  --13 (element)--->  [Detached InternalNode] (native) @32908 [488 bytes]
  --1 (element)--->  [Detached InternalNode] (native) @32910 [432 bytes]
  --4 (element)--->  [Detached ElementIntersectionObserverData] (native) @32902 [72 bytes]

--Similar leaks in this run: 539--
--Retained size of leaked objects: 50.5KB--
[<synthetic>] (synthetic) @1 [10.3MB]
  --6 (shortcut)--->  [Window / https://blog.tubone-project24.xyz] (object) @6227 [62KB]
  --___replace (property)--->  [<closure>] (closure) @43377 [76 bytes]
  --context (internal)--->  [<function scope>] (object) @86955 [724 bytes]
  --a (variable)--->  [Module] (object) @111921 [6.1KB]
  --get version (property)--->  [version] (closure) @251899 [76 bytes]
  --context (internal)--->  [<function scope>] (object) @145921 [6.3KB]
  --Qn (variable)--->  [y] (object) @430005 [368 bytes]
  --props (property)--->  [Object] (object) @430411 [28 bytes]
  --children (property)--->  [Object] (object) @488191 [296 bytes]
  --props (property)--->  [Object] (object) @491187 [56 bytes]
  --children (property)--->  [Object] (object) @430109 [1.2KB]
  --__ (property)--->  [Object] (object) @449557 [1.1KB]
  --__ (property)--->  [Object] (object) @449577 [940 bytes]
  --__ (property)--->  [Object] (object) @449591 [736 bytes]
  --__d (property)--->  [Detached HTMLDivElement] (native) @321005 [468 bytes]
  --5 (element)--->  [Detached HTMLDivElement] (native) @321003 [384 bytes]
  --5 (element)--->  [Detached HTMLDivElement] (native) @321001 [384 bytes]
  --6 (element)--->  [Detached HTMLDivElement] (native) @322265 [14.9KB]
  --8 (element)--->  [Detached HTMLElement] (native) @320611 [26.8KB]
  --5 (element)--->  [Detached HTMLDivElement] (native) @320613 [23.9KB]
  --6 (element)--->  [Detached Text] (native) @321973 [160 bytes]
  --6 (element)--->  [Detached HTMLImageElement] (native) @321299 [704 bytes]
  --7 (element)--->  [Detached Text] (native) @321303 [160 bytes]
  --6 (element)--->  [Detached HTMLParagraphElement] (native) @321331 [2.2KB]
  --8 (element)--->  [Detached Text] (native) @321335 [160 bytes]
  --6 (element)--->  [Detached HTMLHeadingElement] (native) @321343 [544 bytes]
  --8 (element)--->  [Detached Text] (native) @321347 [160 bytes]
  --6 (element)--->  [Detached HTMLParagraphElement] (native) @321355 [456 bytes]
  --8 (element)--->  [Detached Text] (native) @321359 [160 bytes]
  --6 (element)--->  [Detached HTMLParagraphElement] (native) @321367 [456 bytes]
  --8 (element)--->  [Detached Text] (native) @321371 [160 bytes]
  --6 (element)--->  [Detached HTMLImageElement] (native) @321375 [704 bytes]
  --7 (element)--->  [Detached Text] (native) @321379 [160 bytes]
  --6 (element)--->  [Detached HTMLParagraphElement] (native) @321385 [456 bytes]
  --8 (element)--->  [Detached Text] (native) @321389 [160 bytes]
  --6 (element)--->  [Detached HTMLHeadingElement] (native) @321399 [544 bytes]
  --8 (element)--->  [Detached Text] (native) @321405 [160 bytes]
  --6 (element)--->  [Detached HTMLDivElement] (native) @321481 [4.6KB]
  --8 (element)--->  [Detached Text] (native) @321485 [160 bytes]
  --6 (element)--->  [Detached HTMLBRElement] (native) @321489 [296 bytes]
  --6 (element)--->  [Detached Text] (native) @321493 [160 bytes]
  --6 (element)--->  [Detached HTMLElement] (native) @321501 [1.5KB]
  --10 (element)--->  [Detached InternalNode] (native) @33472 [152 bytes]
  --2 (element)--->  [Detached InternalNode] (native) @33474 [56 bytes]
  --1 (element)--->  [Detached NodeList] (native) @50152 [56 bytes]

github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
@tubone24
[file upload] Added file for PR #1398
7f7fd1d
@github-actions GitHub Actions
Copy link
Contributor

Deploy Preview

Deploy path: /home/runner/work/blog/blog/public
Functions path: /home/runner/work/blog/blog/functions/src
Configuration path: /home/runner/work/blog/blog/netlify.toml
Deploying to draft URL...

Logs: https://app.netlify.com/sites/pensive-lamport-5822d2/deploys/6581b4be3edba8240ec783de
Website Draft URL: https://6581b4be3edba8240ec783de--pensive-lamport-5822d2.netlify.app

If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag.
netlify deploy --prod

@github-actions GitHub Actions
Copy link
Contributor

Bundle Analyzer URL

https://6581b4be3edba8240ec783de--pensive-lamport-5822d2.netlify.app/webpack-bundle-analyser

@github-actions GitHub Actions
Copy link
Contributor

Storybook Preview

Deploy path: /home/runner/work/blog/blog/storybook-static
Functions path: /home/runner/work/blog/blog/functions/src
Configuration path: /home/runner/work/blog/blog/netlify.toml
Deploying to draft URL...

Logs: https://app.netlify.com/sites/blog-storybook/deploys/6581b5060c6fb1243c858446
Website Draft URL: https://6581b5060c6fb1243c858446--blog-storybook.netlify.app

If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag.
netlify deploy --prod

github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
@tubone24
[file upload] Added file for PR #1398
5e48372
github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
@tubone24
[file upload] Added file for PR #1398
f1f579d
github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
@tubone24
[file upload] Added file for PR #1398
ffdd8d2
github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
@tubone24
[file upload] Added file for PR #1398
15a367b
@github-actions GitHub Actions
Copy link
Contributor

Lighthouse Score

Desktop

performance: 76
accessibility: 100
best-practices: 100
seo: 92
pwa: 100

Mobile

performance: 78
accessibility: 100
best-practices: 95
seo: 93
pwa: 100

@tubone24 tubone24 merged commit 940d316 into master Dec 19, 2023
34 checks passed
@tubone24 tubone24 deleted the fix-ddd branch December 19, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tubone24 tubone24

Labels
packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tubone24 @coveralls