Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.2 compatibility #51

Open
andreanironi opened this issue Nov 13, 2018 · 2 comments
Open

PHP 7.2 compatibility #51

andreanironi opened this issue Nov 13, 2018 · 2 comments

Comments

@andreanironi
Copy link

PHP 5.x end of life is approaching fast. There are a couple of minor PHP 7.2 incompatibilities in this project, both in gui/index.php:

  • ini_set('magic_quotes_sybase', 0); --> this directive has been removed. I guess it's safe also to disable it.
  • parse_str($_POST['options']); --> parse_str now requires the return parameter to be set. I searched across the code and couldn't find

Would it be ok to raise the PHP minimum version requirement? I can raise a PR if you want

Thank you for this great tool!
@tubalmartin
Copy link
Owner

Hey thanks for noticing! I'll work on this in a few days (too busy right now) but feel free to open a PR 👍

@tubalmartin tubalmartin mentioned this issue Jan 14, 2019
Open
@shital7mahajan
Copy link

Are we having any plans to fix this?

shital7mahajan pushed a commit to shital7mahajan/YUI-CSS-compressor-PHP-port that referenced this issue May 6, 2019
issue Number tubalmartin#51 : Resolved PHP compatibility
0154c2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tubalmartin @andreanironi @shital7mahajan