-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve error message for not yet archived historical weather #188
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this, @tobealive! I had a look on your changes and found two minor issues which might need to be adjusted.
Thank you @kevinmatthes |
42e3f7d
to
67bffd2
Compare
664c406
to
42c698f
Compare
Co-authored-by: Kevin Matthes <[email protected]>
Co-authored-by: Kevin Matthes <[email protected]>
9fc2d11
to
ace2bd7
Compare
Now it just became an different API request if the requested date is younger than 5 days, instead additionally needing to check for null values. I would therefore merge this without adding a test for this function. |
An improved error message for historical weather data that is not yet available in open-meteo's archives.
Resolves #135