Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message for cells with too much text #90

Merged
merged 2 commits into from
Jun 3, 2023
Merged

Conversation

ttsukagoshi
Copy link
Owner

This pull request resolves #75 by informing the user of a rough estimate of the optimal text length in the error message.

Original Message

[SheetsL] Cell content is too long. Please consider splitting the content into multiple cells:
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

Updated Message

[SheetsL] Cell content length exceeds Google's limits. Please consider splitting the content into multiple cells. The following is the estimated maximum length of the cell in question:
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis

Please note that this is a rough estimate and that the actual acceptable text length might differ slightly.

to show a rough estimate of the optimal text length #75
@ttsukagoshi ttsukagoshi added the enhancement New feature or request label Jun 3, 2023
@ttsukagoshi ttsukagoshi self-assigned this Jun 3, 2023
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
58.99% (-0.76% 🔻)
279/473
🟢 Branches 100% 31/31
🟡 Functions 69.23% 9/13
🔴 Lines
58.99% (-0.76% 🔻)
279/473
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴 sheetsl.ts
58.99% (-0.76% 🔻)
100% 69.23%
58.99% (-0.76% 🔻)

Test suite run success

21 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from fcfbf78

@ttsukagoshi ttsukagoshi merged commit 8797c83 into main Jun 3, 2023
@ttsukagoshi ttsukagoshi deleted the text-too-long branch June 3, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with cells with too much text - unknown limit...?
1 participant