Merge pull request kubernetes#78380 from hainesc/master

Add test cases for a helper function in controller manager
tt9133github · Dec 19, 2019 · 8cd8784 · 8cd8784
2 parents 5cb1ec5 + 01f1cf3
commit 8cd8784
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/cmd/controller-manager/app/helper_test.go b/cmd/controller-manager/app/helper_test.go
@@ -60,6 +60,20 @@ func TestIsControllerEnabled(t *testing.T) {
 			disabledByDefaultControllers: []string{"delta", "echo"},
 			expected:                     false,
 		},
+		{
+			name:                         "on by star, not off by name",
+			controllerName:               "alpha",
+			controllers:                  []string{"*", "-charlie"},
+			disabledByDefaultControllers: []string{"delta", "echo"},
+			expected:                     true,
+		},
+		{
+			name:                         "off by name with star",
+			controllerName:               "charlie",
+			controllers:                  []string{"*", "-charlie"},
+			disabledByDefaultControllers: []string{"delta", "echo"},
+			expected:                     false,
+		},
 		{
 			name:                         "off by default implicit, no star",
 			controllerName:               "foxtrot",