Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test for multifiles #88

Closed
wants to merge 6 commits into from
Closed

fix: test for multifiles #88

wants to merge 6 commits into from

Conversation

tsuyoshicho
Copy link
Owner

No description provided.

@tsuyoshicho tsuyoshicho self-assigned this Sep 22, 2023
github-actions[bot]
github-actions bot reviewed Sep 22, 2023
View reviewed changes
script.sh Outdated
@@ -57,6 +57,12 @@ export REVIEWDOG_GITHUB_API_TOKEN="${INPUT_GITHUB_TOKEN}"
# safe extract files/dirs
TARGETS_LIST="${INPUT_TARGET:-.}"

echo 'work dir: ${INPUT_WORKDIR}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Expressions don't expand in single quotes, use double quotes for that. SC2016

script.sh Outdated
@@ -57,6 +57,12 @@ export REVIEWDOG_GITHUB_API_TOKEN="${INPUT_GITHUB_TOKEN}"
# safe extract files/dirs
TARGETS_LIST="${INPUT_TARGET:-.}"

echo 'work dir: ${INPUT_WORKDIR}'
echo 'work dir real path: ' $(pwd)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
Quote this to prevent word splitting. SC2046

script.sh Outdated
@@ -57,6 +57,12 @@ export REVIEWDOG_GITHUB_API_TOKEN="${INPUT_GITHUB_TOKEN}"
# safe extract files/dirs
TARGETS_LIST="${INPUT_TARGET:-.}"

echo 'work dir: ${INPUT_WORKDIR}'
echo 'work dir real path: ' $(pwd)
echo 'target files/dirs: ${TARGETS_LIST}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Expressions don't expand in single quotes, use double quotes for that. SC2016

@tsuyoshicho
Copy link
Owner Author

re-PR, close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@tsuyoshicho tsuyoshicho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tsuyoshicho