Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: JSON format support #162

Merged
merged 11 commits into from
Aug 3, 2024
Merged

feat: JSON format support #162

merged 11 commits into from
Aug 3, 2024

Conversation

tsuyoshicho
Copy link
Owner

@tsuyoshicho tsuyoshicho commented Jul 27, 2024

Pull Request detail

Related issues or PRs/関連issueやPR

close #38

Fix or Add/Remove in this PR/このプルリクエストでやったこと

JSON利用に変更

オプションOnにするには
mypy 1.11 以上が必要

Do not fix or add/remove this PR/このプルリクエストでやらなかったこと

  • 設定の互換性の破壊(ignore_noteは無駄なのだが、維持している)

Pros and Cons/メリットとデメリット

note表示を綺麗に止める

Test/動作確認

Test item list up with checkbox, checked after tested./チェックボックス式にし、確認後チェックする。

TODO

Keep inter version compatibility

@tsuyoshicho tsuyoshicho self-assigned this Jul 27, 2024
@tsuyoshicho tsuyoshicho changed the title feat: Add pyright_to_rdjson.py file from jordemort/action-pyright feat: JSON format support Jul 27, 2024
@tsuyoshicho tsuyoshicho added the bump:major Bump up major version label Aug 3, 2024
@tsuyoshicho tsuyoshicho merged commit 759c01e into master Aug 3, 2024
8 checks passed
@tsuyoshicho tsuyoshicho deleted the feature/json branch August 3, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:major Bump up major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple reviews generated for multiline mypy error
1 participant