Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: functions to read and interpolate from all constituents to address #91 #137

Merged
merged 6 commits into from
Dec 24, 2022

Conversation

tsutterley
Copy link
Owner

@tsutterley tsutterley commented Dec 22, 2022

test: switch interpolation test to soft tabs
to do: need to see if these are actual optimizations

…address #91

to do: need to add tests that outputs are as expected
to do: need to see if these are actual optimizations
test: switch interpolation test to soft tabs
fix: setting masks
fix: str iterable in FES
fix: iterate over fields
feat: add iterator to constituent class
feat: add pop and update to constituents class
fix: raise exception if constituent not in list
@codecov
Copy link

codecov bot commented Dec 24, 2022

Codecov Report

Base: 64.80% // Head: 63.81% // Decreases project coverage by -0.98% ⚠️

Coverage data is based on head (cf907e1) compared to base (501d1ab).
Patch coverage: 59.80% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   64.80%   63.81%   -0.99%     
==========================================
  Files          44       53       +9     
  Lines        6316     7423    +1107     
  Branches      638      769     +131     
==========================================
+ Hits         4093     4737     +644     
- Misses       1998     2379     +381     
- Partials      225      307      +82     
Flag Coverage Δ
unittests 63.81% <59.80%> (-0.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyTMD/calc_astrol_longitudes.py 72.50% <ø> (ø)
pyTMD/load_constituent.py 88.88% <ø> (ø)
pyTMD/load_nodal_corrections.py 98.75% <ø> (ø)
pyTMD/read_tide_model.py 26.43% <1.85%> (-11.67%) ⬇️
pyTMD/read_netcdf_model.py 27.90% <4.76%> (-26.02%) ⬇️
pyTMD/read_GOT_model.py 33.33% <6.66%> (-57.04%) ⬇️
pyTMD/read_FES_model.py 30.00% <10.00%> (-16.31%) ⬇️
pyTMD/calc_delta_time.py 57.14% <25.00%> (-42.86%) ⬇️
pyTMD/iers_mean_pole.py 43.75% <25.00%> (-37.39%) ⬇️
pyTMD/infer_minor_corrections.py 33.33% <25.00%> (-63.70%) ⬇️
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsutterley tsutterley merged commit e38d049 into main Dec 24, 2022
@tsutterley tsutterley deleted the io branch December 24, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant