-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grpcbox for chatterbox performance work #102
Update grpcbox for chatterbox performance work #102
Conversation
772ed14
to
a1d46b5
Compare
I think the github actions Ci needs to be updated to ubuntu 20.04 or it won't run. |
On 25 I get 2 failures because of:
|
I'm pretty sure this is some pre-existing bitrot? |
I thnk the previous CI job needs to be cancelled so it can retry with the new workflow file |
Yea, it is bitrot. If you have any ideas though let me know :). I've been banging my head against chatterbox on otp-25/26. Tests are going to fail on 23 so need to drop that. |
I assume the bundled certificates have become obsolete somehow (I decoded them and they're still chronologically valid) but maybe RSA1024 is no longer allowed? |
Ah yup, I thought I tried adding that back to allowed and it still failed so thought it wasn't the issue. But generating new keys worked. |
Ok, I will rebase once you have new keys merged. |
rebar.config
Outdated
@@ -1,6 +1,6 @@ | |||
{erl_opts, [debug_info]}. | |||
|
|||
{deps, [{chatterbox, {pkg, ts_chatterbox}}, | |||
{deps, [{chatterbox, ".*", {git, "https://github.com/novalabsxyz/chatterbox", {branch, "adt/perf-nodebug"}}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch this to tsloughter/chatterbox
and I'll merge after the rebase. Not ready to make a chatterbox release with such big changes yet but want it easy to test it for others.
bd4f082
to
2ef767c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
- Coverage 39.75% 39.51% -0.24%
==========================================
Files 28 28
Lines 2118 2118
==========================================
- Hits 842 837 -5
- Misses 1276 1281 +5
☔ View full report in Codecov by Sentry. |
Depends on tsloughter/chatterbox#22