Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpcbox for chatterbox performance work #102

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

Vagabond
Copy link
Contributor

@Vagabond Vagabond commented Jun 1, 2023

@Vagabond Vagabond force-pushed the adt/chatterbox-update branch from 772ed14 to a1d46b5 Compare June 1, 2023 17:39
@tsloughter
Copy link
Owner

I think the github actions Ci needs to be updated to ubuntu 20.04 or it won't run.

@tsloughter
Copy link
Owner

On 25 I get 2 failures because of:

{handshake_failure,
                                                          "TLS server: In state hello at ssl_handshake.erl:2109 generated SERVER ALERT: Fatal - Handshake Failure\n unacceptable_rsa_key"}}}

@Vagabond
Copy link
Contributor Author

Vagabond commented Jun 2, 2023

On 25 I get 2 failures because of:

{handshake_failure,
                                                          "TLS server: In state hello at ssl_handshake.erl:2109 generated SERVER ALERT: Fatal - Handshake Failure\n unacceptable_rsa_key"}}}

I'm pretty sure this is some pre-existing bitrot?

@Vagabond
Copy link
Contributor Author

Vagabond commented Jun 2, 2023

I thnk the previous CI job needs to be cancelled so it can retry with the new workflow file

@tsloughter
Copy link
Owner

Yea, it is bitrot. If you have any ideas though let me know :). I've been banging my head against chatterbox on otp-25/26.

Tests are going to fail on 23 so need to drop that.

@Vagabond
Copy link
Contributor Author

Vagabond commented Jun 7, 2023

I assume the bundled certificates have become obsolete somehow (I decoded them and they're still chronologically valid) but maybe RSA1024 is no longer allowed?

@tsloughter
Copy link
Owner

Ah yup, I thought I tried adding that back to allowed and it still failed so thought it wasn't the issue. But generating new keys worked.

@Vagabond
Copy link
Contributor Author

Vagabond commented Jun 7, 2023

Ok, I will rebase once you have new keys merged.

rebar.config Outdated
@@ -1,6 +1,6 @@
{erl_opts, [debug_info]}.

{deps, [{chatterbox, {pkg, ts_chatterbox}},
{deps, [{chatterbox, ".*", {git, "https://github.com/novalabsxyz/chatterbox", {branch, "adt/perf-nodebug"}}},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch this to tsloughter/chatterbox and I'll merge after the rebase. Not ready to make a chatterbox release with such big changes yet but want it easy to test it for others.

@Vagabond Vagabond force-pushed the adt/chatterbox-update branch from bd4f082 to 2ef767c Compare June 8, 2023 17:48
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.24 ⚠️

Comparison is base (855947e) 39.75% compared to head (2ef767c) 39.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   39.75%   39.51%   -0.24%     
==========================================
  Files          28       28              
  Lines        2118     2118              
==========================================
- Hits          842      837       -5     
- Misses       1276     1281       +5     
Impacted Files Coverage Δ
src/grpcbox_client_stream.erl 68.91% <ø> (-0.42%) ⬇️
src/grpcbox_subchannel.erl 62.22% <40.00%> (-10.51%) ⬇️
src/grpcbox_stream.erl 64.61% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsloughter tsloughter merged commit da0ab58 into tsloughter:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants