removes updating the connection encode_context on trailer encoding #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating the hpack encoding is removed while trailers are broken. Currently they can be sent in a different order than they were encoded. A refactor to have the encoding not happen until the sending is actually done is required to allow for the table to be updated by trailer encoding.
|
Hm, I suppose I should have it also no update the decode context when decoding trailers to be consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating the hpack encoding is removed while trailers are
broken. Currently they can be sent in a different order than they
were encoded. A refactor to have the encoding not happen until
the sending is actually done is required to allow for the table
to be updated by trailer encoding.