Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document RateMap etc #2679

Open
hyanwong opened this issue Jan 10, 2023 · 5 comments
Open

Document RateMap etc #2679

hyanwong opened this issue Jan 10, 2023 · 5 comments
Milestone

Comments

@hyanwong
Copy link
Member

hyanwong commented Jan 10, 2023

At the moment the documentation is in msprime under its own section within Utilities: Rate Maps. Since it is purely a python thing, I wonder if in tskit it should simply live in the Python API documentation. We already have a utility functions section: we could simply make it "Utility classes and functions" and put some of the explanatory stuff there? Some might want to stay in the msprime docs, I guess. There's quite a lot of material in the current msprime file.

@jeromekelleher
Copy link
Member

Do we want to make this a blocker for 0.5.4?

@hyanwong
Copy link
Member Author

hyanwong commented Jan 10, 2023

No, I don't think that's necessary if we want to get 0.5.4 out soon. The msprime version will carry on working and is documented there. It will take some thought to get the docs right, so I think it can just be undocumented for the time being.

@jeromekelleher
Copy link
Member

I think there are good reasons for not documented it yet actually - let's see how the process of cutting it out of msprime goes first and whether we need to make any minor API tweaks first.

@jeromekelleher jeromekelleher added this to the Python 0.5.5 (paper) milestone Jan 11, 2023
@hyanwong
Copy link
Member Author

Yes, I agree.

@hyanwong
Copy link
Member Author

hyanwong commented Oct 25, 2024

Just looking at the API for this again, in the light of wanting to be able to export a HapMap-style recombination rate. I wonder if we want to define class RecombinationMap(RateMap):, and then have read_hapmap (and maybe write_hapmap) as methods of the subclass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants