@FIR-43: Added Zephyr logging and TSI application #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,18 @@ | |||
| CONFIG_LOG=y | |||
| CONFIG_CONSOLE=y | |||
| CONFIG_LOG_PRINTK=y | |||
There was a problem hiding this comment.
Do you need this ?
tsi_app/m85/prj_poll.conf
Outdated
| @@ -0,0 +1,4 @@ | |||
| CONFIG_SHELL=y | |||
| CONFIG_SHELL_BACKEND_SERIAL_INTERRUPT_DRIVEN=n | |||
There was a problem hiding this comment.
Do you need this change ?
tsi_app/m85/sample.yaml
Outdated
| common: | ||
| tags: introduction | ||
| integration_platforms: | ||
| - ek_tsi_skyp |
There was a problem hiding this comment.
You can check if we need to rename this file ? As sample.yml is not clear what it is intended for.
tsi_app/m85/src/main.c
Outdated
| #include <zephyr/logging/log_output.h> | ||
|
|
||
| #define DATA_MAX_DLEN 8 | ||
| #define LOG_MODULE_NAME m85 |
There was a problem hiding this comment.
Should this be TSI_M85 to clearly identify M85
tsi_app/m85/src/main.c
Outdated
| { | ||
|
|
||
| /* TSI banner */ | ||
| printf("!! ------------------------------------------ !! \n"); |
There was a problem hiding this comment.
Can we define this as strings ? Is this a standard practice for the for a boot banner.
atrivedi-tsavoritesi
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added first Zephyr logging and TSI application start point. The prj.conf of this application includes shell capability as well which will be enabled subsequently.