Skip to content

Commit

Permalink
Addressing DNS pull request comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewkroh committed Aug 28, 2015
1 parent a2d19db commit 330a95e
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 14 deletions.
14 changes: 7 additions & 7 deletions etc/packetbeat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,19 +42,19 @@ protocols:
ports: [53]

# include_authorities controls whether or not the dns.authorities field
# (authority resource records) is added to messages. The default is no.
include_authorities: yes
# (authority resource records) is added to messages. The default is false.
include_authorities: true
# include_additionals controls whether or not the dns.additionals field
# (additional resource records) is added to messages. The default is no.
include_additionals: yes
# (additional resource records) is added to messages. The default is false.
include_additionals: true

# send_request and send_response control whether or not the stringified DNS
# request and response message are added to the result. The default is no.
# request and response message are added to the result. The default is false.
# Nearly all data about the request/response is available in the dns.*
# fields, but this can be useful if you need visibility specifically
# into the request or the response.
#send_request: yes
#send_response: yes
#send_request: true
#send_response: true

http:

Expand Down
14 changes: 7 additions & 7 deletions packetbeat.dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,19 +46,19 @@ protocols:
ports: [53]

# include_authorities controls whether or not the dns.authorities field
# (authority resource records) is added to messages. The default is no.
include_authorities: yes
# (authority resource records) is added to messages. The default is false.
include_authorities: true
# include_additionals controls whether or not the dns.additionals field
# (additional resource records) is added to messages. The default is no.
include_additionals: yes
# (additional resource records) is added to messages. The default is false.
include_additionals: true

# send_request and send_response control whether or not the stringified DNS
# request and response message are added to the result. The default is no.
# request and response message are added to the result. The default is false.
# Nearly all data about the request/response is available in the dns.*
# fields, but this can be useful if you need visibility specifically
# into the request or the response.
#send_request: yes
#send_response: yes
#send_request: false
#send_response: flase

http:

Expand Down
2 changes: 2 additions & 0 deletions protos/dns/dns.go
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,8 @@ func (dns *Dns) GetPorts() []int {
}

func (dns *Dns) ParseUdp(pkt *protos.Packet) {
defer logp.Recover("Dns ParseUdp")

logp.Debug("dns", "Parsing packet addressed with %s of length %d.",
pkt.Tuple.String(), len(pkt.Payload))

Expand Down

0 comments on commit 330a95e

Please sign in to comment.