Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: Bugfix: Print all command line help text to stderr, not stdout #393

Merged
merged 2 commits into from
Apr 28, 2019

Conversation

fxkr
Copy link
Contributor

@fxkr fxkr commented Apr 23, 2019

Previously some was printed to stderr, some was printed to stdout.

This caused the help text to be garbled sometimes, e.g. in certain terminals. Before fix:

image

After fix:

image

(Actually I first noticed this when running vegeta on a remote system using something like fabric, where stdout and stderr are captured separately and returned as two strings, so any interleaving gets lost.)

Background

Checklist

  • Git commit messages conform to community standards.
  • Each Git commit represents meaningful milestones or atomic units of work.
  • Changed or added code is covered by appropriate tests.

Previously some was printed to stderr, some was printed to stdout.
@fxkr fxkr requested review from tsenart and xla as code owners April 23, 2019 02:58
Copy link
Owner

@tsenart tsenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tsenart tsenart merged commit 579df76 into tsenart:master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants