feat(mikro-orm): rename all occurrences of connection #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derevnjuk
force-pushed
the
feat-#1741/rename-all-occurrences-of-connection
branch
from
74365ac to
66dfd6e
Compare
derevnjuk
force-pushed
the
feat-#1741/rename-all-occurrences-of-connection
branch
from
66dfd6e to
0e3f587
Compare
derevnjuk
force-pushed
the
feat-#1741/rename-all-occurrences-of-connection
branch
from
e95f5c9 to
ea4e2c0
Compare
derevnjuk
force-pushed
the
feat-#1741/rename-all-occurrences-of-connection
branch
from
ea4e2c0 to
879bee9
Compare
Romakita
approved these changes
Jan 30, 2022
|
🎉 This PR is included in version 6.100.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 7.0.0-beta.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
As discussed in #1742 (comment), we should rename all occurrences of
connectionto satisfy the naming convention in MikroOrm.Deprecations
MikroOrminstance, useTransactionOptions.contextNamesinceTransactionOptions.connectionNameis deprecated.DbContext::getContextmethod is deprecated, useDbContext::entriesinstead.MikroOrmRegistry::createConnectionmethod is deprecated, instead useMikroOrmRegistry::registerto register a particularMikroOrminstance.MikroOrmRegistry::closeConnectionsmethod is deprecated, instead useMikroOrmRegistry::clearto dispose registeredMikroOrminstances and clear the registry.Todos
closes #1741