[BUG] Optional forgein key cause ReferenceError in ESM mode

[vangie]

Describe the bug

my project is run in ESM, I using Prisma create a optional forgein key relation between two Model，after npx prisma migrate, then throw following error on start up project.

file:///Users/duwan/Workspaces/babelcloud/babel-agent/node_modules/.pnpm/@[email protected]_@[email protected][email protected]__@[email protected]_@[email protected]_@t_vf7jy3uhtsnnr6bz5e5qbyw76e/node_modules/@tsed/prisma/lib/.schema/models/ConversationModel.js:119
    __metadata("design:type", AssignmentModel)
                              ^

ReferenceError: Cannot access 'AssignmentModel' before initialization
    at file:///Users/duwan/Workspaces/babelcloud/babel-agent/node_modules/.pnpm/@[email protected]_@[email protected][email protected]__@[email protected]_@[email protected]_@t_vf7jy3uhtsnnr6bz5e5qbyw76e/node_modules/@tsed/prisma/lib/.schema/models/ConversationModel.js:119:31
    at ModuleJob.run (node:internal/modules/esm/module_job:218:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:329:24)
    at async loadESM (node:internal/process/esm_loader:28:7)
    at async handleMainPromise (node:internal/modules/run_main:113:12)

To Reproduce

model Conversation {
  id           String      @id @default(dbgenerated("gen_random_uuid()")) @db.Uuid
  assignmentId String?     @map("assignment_id") @db.Uuid
  assignment   Assignment? @relation(fields: [assignmentId], references: [id], onDelete: NoAction, onUpdate: NoAction)

  @@map("conversation")
}

model Assignment {
  id                String         @id @default(dbgenerated("gen_random_uuid()")) @db.Uuid
  conversations     Conversation[]

  @@map("assignment")
}

cause following error

file:///Users/duwan/Workspaces/babelcloud/babel-agent/node_modules/.pnpm/@[email protected]_@[email protected][email protected]__@[email protected]_@[email protected]_@t_vf7jy3uhtsnnr6bz5e5qbyw76e/node_modules/@tsed/prisma/lib/.schema/models/ConversationModel.js:119
    __metadata("design:type", AssignmentModel)
                              ^

ReferenceError: Cannot access 'AssignmentModel' before initialization
    at file:///Users/duwan/Workspaces/babelcloud/babel-agent/node_modules/.pnpm/@[email protected]_@[email protected][email protected]__@[email protected]_@[email protected]_@t_vf7jy3uhtsnnr6bz5e5qbyw76e/node_modules/@tsed/prisma/lib/.schema/models/ConversationModel.js:119:31
    at ModuleJob.run (node:internal/modules/esm/module_job:218:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:329:24)
    at async loadESM (node:internal/process/esm_loader:28:7)
    at async handleMainPromise (node:internal/modules/run_main:113:12)

I found that if remove the '?' after String and Assignment as following, it will not cause the error.

model Conversation {

  assignmentId String     @map("assignment_id") @db.Uuid
  assignment   Assignment @relation(fields: [assignmentId], references: [id], onDelete: NoAction, onUpdate: NoAction)

}

Expected behavior

file:///Users/duwan/Workspaces/babelcloud/babel-agent/node_modules/.pnpm/@tSed+prisma@7.83.3_@prisma[email protected]_prisma@5.20.0__@tsed+core@7.83.3_@tsed+di@7.83.3_@t_vf7jy3uhtsnnr6bz5e5qbyw76e/node_modules/@tsed/prisma/lib/.schema/models/ConversationModel.js

...
__decorate([
    Property(() => AssignmentModel),
    Allow(null),
    __metadata("design:type", AssignmentModel)
], ConversationModel.prototype, "assignment", void 0);

if i change the secord AssignmentModel to Object manually, everything is well。

...
__decorate([
    Property(() => AssignmentModel),
    Allow(null),
    __metadata("design:type", Object)
], ConversationModel.prototype, "assignment", void 0);

Code snippets

No response

Repository URL example

No response

OS

macOS

Node version

v20.11.1

Library version

v7.83.3

Additional context

ESM mode

[Romakita]

Hi @vangie
Thanks for the issue.
Metadata are generated by typescript not by the plugin, so how I supposed to fix that? Have you a recent typescript version?

See you

[vangie]

Hi @vangie Thanks for the issue. Metadata are generated by typescript not by the plugin, so how I supposed to fix that? Have you a recent typescript version?

See you

@Romakita

❯ npx tsc --version
Version 5.5.3

[Romakita]

@vangie It seems to be solved by that:

  if (isRequired && !isList && !isNullable && hasCircularRef && ["inputObjectTypes", "enumTypes"].includes(location)) {
    hasCircularRef && !isList && field.model.addImportDeclaration("@tsed/core", "Relation", true);
    TSType = `Relation<${TSType}>`;
  }

But in this case, the code isn't generated as expected. You should have a Relation in the generated code.

See:

tsed/packages/orm/prisma/src/generator/transform/transformScalarToType.ts

Line 44 in dfa942b

if (isRequired && !isList && !isNullable && hasCircularRef && ["inputObjectTypes", "enumTypes"].includes(location)) {

Maybe the condition isn't correct in your case.

[Romakita]

PR #2864

[github-actions]

🎉 Are you happy?

If you appreciated the support, know that it is free and is carried out on personal time ;)

A support, even a little bit makes a difference for me and continues to bring you answers!

[github-actions]

🎉 Are you happy?

If you appreciated the support, know that it is free and is carried out on personal time ;)

A support, even a little bit makes a difference for me and continues to bring you answers!

[Romakita]

🎉 This issue has been resolved in version 7.83.4 🎉

The release is available on:

• v7.83.4
• GitHub release

Your semantic-release bot 📦🚀

[vangie]

@Romakita My problem is resolved, Thanks!

[Romakita]

🎉 This issue has been resolved in version 8.0.0-beta.10 🎉

The release is available on:

• v8.0.0-beta.10
• GitHub release

Your semantic-release bot 📦🚀

[Romakita]

🎉 This issue has been resolved in version 8.0.0 🎉

The release is available on:

• v8.0.0
• GitHub release

Your semantic-release bot 📦🚀