Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cache-manager to latest to support refreshThreshold #2145

Closed
1 task
petermenkeepsilon opened this issue Nov 2, 2022 · 5 comments · Fixed by #2151
Closed
1 task

Update cache-manager to latest to support refreshThreshold #2145

petermenkeepsilon opened this issue Nov 2, 2022 · 5 comments · Fixed by #2151

Comments

@petermenkeepsilon
Copy link

Information

Is your feature request related to a problem? Please describe.
When using the "memory" cache and the @UseCache decorator, the refreshThreshold option does not work because cache-manager@^4 does not have a ttl method. cache-manager@^5 does have the ttl method.

Describe the solution you'd like
Update the dependencies of @tsed/platform-cache to include cache-manager@^5 instead of cache-manager@^4, so that the "memory" cache store works with the refreshThreshold option of @UseCache.

Describe alternatives you've considered
Suggest in the documentation an alternative memory cache package to use that satisfies the above requirements.

Acceptance criteria

  • The "memory" cache store works with the refreshThreshold option of @UseCache.
@Romakita
Copy link
Collaborator

Romakita commented Nov 3, 2022

Hello @petermenkeepsilon
Thanks for your Issue :)

PR is welcome. I think the change will be on the package.json here :

https://github.com/tsedio/tsed/blob/production/packages/platform/platform-cache/package.json#L25

The change isn't a breaking change so it could be integrated on the v7 release :)

See you
Romain

@Romakita Romakita moved this from To do to In progress in Global Board Nov 7, 2022
@Romakita Romakita moved this from In progress to Review approved in Global Board Nov 7, 2022
@Romakita
Copy link
Collaborator

Romakita commented Nov 7, 2022

PR ready

Repository owner moved this from Review approved to Done in Global Board Nov 8, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

🎉 Are you happy?

If you appreciated the support, know that it is free and is carried out on personal time ;)

A support, even a little bit makes a difference for me and continues to bring you answers!

github opencollective

@Romakita
Copy link
Collaborator

Romakita commented Nov 8, 2022

🎉 This issue has been resolved in version 7.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@petermenkeepsilon
Copy link
Author

Thanks you @Romakita!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants