-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cache-manager to latest to support refreshThreshold #2145
Labels
Comments
Hello @petermenkeepsilon PR is welcome. I think the change will be on the package.json here : The change isn't a breaking change so it could be integrated on the v7 release :) See you |
PR ready |
Romakita
added a commit
that referenced
this issue
Nov 8, 2022
Romakita
added a commit
that referenced
this issue
Nov 8, 2022
Repository owner
moved this from Review approved
to Done
in Global Board
Nov 8, 2022
🎉 This issue has been resolved in version 7.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Thanks you @Romakita! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Information
Is your feature request related to a problem? Please describe.
When using the "memory" cache and the
@UseCache
decorator, therefreshThreshold
option does not work because cache-manager@^4 does not have attl
method. cache-manager@^5 does have thettl
method.Describe the solution you'd like
Update the dependencies of
@tsed/platform-cache
to include cache-manager@^5 instead of cache-manager@^4, so that the "memory" cache store works with therefreshThreshold
option of@UseCache
.Describe alternatives you've considered
Suggest in the documentation an alternative memory cache package to use that satisfies the above requirements.
Acceptance criteria
refreshThreshold
option of@UseCache
.The text was updated successfully, but these errors were encountered: