Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CVE-2022-24434 high security vulnerability in platform-express > multer > busboy > dicer #1919

Closed
cyraid opened this issue May 31, 2022 · 12 comments

Comments

@cyraid
Copy link

cyraid commented May 31, 2022

Information

  • Version: 6.114.14
  • Packages: @tsed/platform-express > multer > busboy > dicer

There is a high security vulnerability found after doing npm audit, as when I installed it gave me an alert.
GHSA-wm7h-9275-46v2

If I'm not mistaken, for platform-express, shouldn't multer be a peer dependency?

@Romakita
Copy link
Collaborator

Romakita commented Jun 1, 2022

Hello @cyraid
Look the constraint here: https://github.com/tsedio/tsed/blob/production/packages/platform/platform-express/package.json#L60

The version isn’t fixed. You can install the multer as your own dependencies.

If I'm not mistaken, for platform-express, shouldn't multer be a peer dependency?

I cannot change that without causing a breaking change. And this module is imported in the code. Maybe in v7 I’ll change that.

See you

@cyraid
Copy link
Author

cyraid commented Jun 1, 2022

I'm using the newest multer in the dependencies but the warning still pops up.

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

🎉 Are you happy?

If you appreciated the support, know that it is free and is carried out on personal time ;)

A support, even a little bit makes a difference for me and continues to bring you answers!

github opencollective

@Romakita
Copy link
Collaborator

Romakita commented Jun 1, 2022

🎉 This issue has been resolved in version 6.114.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Romakita
Copy link
Collaborator

Romakita commented Jun 1, 2022

Maybe you need to use npm dedup.

@cyraid
Copy link
Author

cyraid commented Jun 1, 2022

That was quick! Though I think 1.4.4 still is affected. The message says it was fixed in 1.4.4-lts.1, and there's also 1.4.5-lts.1 now. npm dedup didn't work for me. :(

npm WARN deprecated [email protected]: Multer 1.x is affected by CVE-2022-24434. This is fixed in v1.4.4-lts.1 which drops support for versions of Node.js before 6. Please upgrade to at least Node.js 6
and version 1.4.4-lts.1 of Multer. If you need support for older versions of Node.js, we are open to accepting patches that would fix the CVE on the main 1.x release line, whilst maintaining compatibility with Node.js 0.10.

Does npm audit not show that for you? Also, thanks for the quick replies! Man you're fast. haha

@Romakita
Copy link
Collaborator

Romakita commented Jun 2, 2022

Ok i’ll update the dependencies to lts ;)

@Romakita
Copy link
Collaborator

Romakita commented Jun 2, 2022

It’s strange, if dedup doesn’t works it means you hzven’t duplicated multer. Look in node_modules/@tsed/platform-express/node_modules. Check if you have a multer package.

You have npm 8?

@nabhasalakkat
Copy link

I'm using v6.114.15 of platform-express but still getting the @tsed/platform-express > multer > busboy > dicer vulnerability

@Romakita
Copy link
Collaborator

Romakita commented Jun 2, 2022

yes the PR isn't merged with the latest dependencies. I'll do that ASAP.

@cyraid
Copy link
Author

cyraid commented Jun 3, 2022

Thank you @Romakita!

@Romakita
Copy link
Collaborator

🎉 This issue has been resolved in version 7.0.0-beta.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants