fix(platform-response-filter): update getContentType detection

tsedio · Mar 24, 2024 · c18add2 · c18add2
1 parent b4e01e7
commit c18add2
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/packages/platform/platform-response-filter/src/utils/getContentType.spec.ts b/packages/platform/platform-response-filter/src/utils/getContentType.spec.ts
@@ -6,7 +6,7 @@ describe("getContentType", () => {
   beforeEach(() => PlatformTest.create());
   afterEach(() => PlatformTest.reset());
 
-  it("should return the content type (undefined)", () => {
+  it("should return the content type (application/json) if the data is an object", () => {
     class TestController {
       @Get("/")
       get() {}
@@ -22,6 +22,22 @@ describe("getContentType", () => {
       ctx
     );
 
+    expect(result).toEqual("application/json");
+  });
+
+  it("should return the content type (Buffer -> undefined)", () => {
+    class TestController {
+      @Get("/")
+      get(): Buffer {
+        return Buffer.from("test");
+      }
+    }
+
+    const ctx = PlatformTest.createRequestContext();
+    ctx.endpoint = EndpointMetadata.get(TestController, "get");
+
+    const result = getContentType(Buffer.from("test"), ctx);
+
     expect(result).toEqual(undefined);
   });
   it("should return the content type (object - application/json)", () => {

diff --git a/packages/platform/platform-response-filter/src/utils/getContentType.ts b/packages/platform/platform-response-filter/src/utils/getContentType.ts
@@ -24,7 +24,7 @@ export function getContentType(data: any, ctx: BaseContext) {
     return "text/html";
   }
 
-  if (contentType === "" && isObject(data)) {
+  if (contentType === "" && isObject(data) && !Buffer.isBuffer(data)) {
     return "application/json";
   }
 }