fix: set useDefineForClassFields to false in tsconfig

package.json

@@ -28,7 +28,7 @@
     "configure": "monorepo ci configure",
     "clean": "monorepo clean workspace",
     "test": "vitest run",
-    "test:ci": "yarn test:lint && yarn test:core && yarn test:specs && yarn test:platform && yarn test:integration && yarn test:graphql && yarn test:orm && yarn test:security && yarn test:formio && yarn test:third-parties",
+    "test:ci": "yarn test:lint && yarn test:core && yarn test:specs && yarn test:platform && yarn test:integration && yarn test:graphql && yarn test:orm && yarn test:security && yarn test:third-parties",
     "test:lint": "eslint '**/*.{ts,js}'",
     "test:lint:fix": "eslint '**/*.{ts,js}' --fix",
     "test:core": "lerna run test:ci --scope '@tsed/{core,di,common,engines,normalize-path}' --stream --concurrency 2",
@@ -38,7 +38,7 @@
     "test:graphql": "lerna run test:ci --scope '@tsed/{apollo,typegraphql}' --stream",
     "test:security": "lerna run test:ci --scope '@tsed/{jwks,oidc-provider,passport,oidc-provider-plugin-wildcard-redirect-uri}' --stream",
     "test:specs": "lerna run test --scope '@tsed/{ajv,exceptions,json-mapper,schema,swagger}' --stream --concurrency 2",
-    "test:third-parties": "lerna run test:ci --scope '@tsed/{agenda,bullmq,components-scan,event-emitter,formio,pulse,sse,socketio,stripe,temporal,terminus,vike,vite-ssr-plugin,schema-formio,formio}' --stream --concurrency 4",
+    "test:third-parties": "lerna run test:ci --scope '@tsed/{agenda,bullmq,components-scan,event-emitter,formio,pulse,sse,socketio,stripe,temporal,terminus,vike,vite-ssr-plugin,schema-formio,formio}' --stream --concurrency 1",
     "coverage": "merge-istanbul --out coverage/coverage-final.json \"**/packages/**/coverage/coverage-final.json\" && nyc report --reporter text --reporter html --reporter lcov -t coverage --report-dir coverage",
     "barrels": "lerna run barrels",
     "build": "monorepo build --verbose",

packages/core/src/decorators/enumerable.spec.ts

@@ -48,13 +48,14 @@ describe("Enumerable", () => {
     expect(getEnumerableKeys(new Test1())).toEqual(["test", "name"]);
     expect(Object.keys(new Test1())).toEqual(["test", "name"]);
     expect(Object.getOwnPropertyNames(new Test1())).toEqual(["test", "name"]);
-    expect(Reflect.ownKeys(new Test2())).toEqual(["parentProp", "prop", "test", "name", "_privateTest"]);
+    expect(Reflect.ownKeys(new Test2())).toEqual(["prop", "test", "name", "_privateTest"]);
   });
 
   it("should have some keys with Test2", () => {
-    expect(getEnumerableKeys(new Test2())).toEqual(["parentProp", "prop", "test", "name", "first", "privateTest"]);
-    expect(Object.keys(new Test2())).toEqual(["parentProp", "prop", "test", "name", "_privateTest"]);
-    expect(Object.getOwnPropertyNames(new Test2())).toEqual(["parentProp", "prop", "test", "name", "_privateTest"]);
-    expect(Reflect.ownKeys(new Test2())).toEqual(["parentProp", "prop", "test", "name", "_privateTest"]);
+    expect(getEnumerableKeys(new Test2())).toEqual(["prop", "test", "name", "first", "privateTest", "parentProp"]);
+    expect(Object.keys(new Test2())).toEqual(["prop", "test", "name", "_privateTest"]);
+    expect(Object.getOwnPropertyNames(new Test2())).toEqual(["prop", "test", "name", "_privateTest"]);
+    expect(Reflect.ownKeys(new Test2())).toEqual(["prop", "test", "name", "_privateTest"]);
+    expect(Reflect.ownKeys(new Test2())).toEqual(["prop", "test", "name", "_privateTest"]);
   });
 });

packages/core/vitest.config.mts

@@ -10,12 +10,12 @@ export default defineConfig(
       coverage: {
         ...presets.test.coverage,
         thresholds: {
-          statements: 0,
-          branches: 0,
-          functions: 0,
-          lines: 0
+          statements: 97.85,
+          branches: 94.12,
+          functions: 94.54,
+          lines: 97.85
         }
       }
     }
   }
-);
+);

packages/di/src/common/services/InjectorService.ts

@@ -448,9 +448,12 @@ export class InjectorService extends Container {
 
     get = resolver(this, locals, {...invokeOptions, options});
 
+    catchError(() => Reflect.deleteProperty(instance, propertyKey));
     catchError(() =>
-      Object.defineProperty(instance, propertyKey, {
-        get
+      Reflect.defineProperty(instance, propertyKey, {
+        get,
+        enumerable: true,
+        configurable: true
       })
     );
   }
@@ -469,7 +472,8 @@ export class InjectorService extends Container {
       configurable: true
     };
 
-    catchError(() => Object.defineProperty(instance, propertyKey, descriptor));
+    catchError(() => Reflect.deleteProperty(instance, propertyKey));
+    catchError(() => Reflect.defineProperty(instance, propertyKey, descriptor));
   }
 
   /**
@@ -498,6 +502,7 @@ export class InjectorService extends Container {
       configurable: true
     };
 
+    catchError(() => Reflect.deleteProperty(instance, propertyKey));
     catchError(() => Object.defineProperty(instance, propertyKey, descriptor));
   }
 

packages/di/src/node/integration/async-factory-invoke.spec.ts

@@ -30,6 +30,7 @@ describe("AsyncFactory", () => {
     const service = DITest.get<MyService>(MyService);
 
     const result = service.me();
+
     expect(result).toEqual("id");
   });
 
@@ -44,6 +45,7 @@ describe("AsyncFactory", () => {
     const service = await DITest.invoke<MyService>(MyService, []);
 
     const result = service.me();
+
     expect(result).toEqual("id");
   });
 

packages/di/src/node/services/DITest.ts

@@ -2,7 +2,6 @@ import {Env, getValue, isClass, isPromise, setValue} from "@tsed/core";
 import {$log} from "@tsed/logger";
 import {
   createContainer,
-  type ImportTokenProviderOpts,
   InjectorService,
   LocalsContainer,
   OnInit,
@@ -103,11 +102,14 @@ export class DITest {
     const instance: OnInit = DITest.injector.invoke(target, locals, {rebuild: true});
 
     if (instance && instance.$onInit) {
-      // await instance.$onInit();
       const result = instance.$onInit();
 
       if (result instanceof Promise) {
-        return result.then(() => instance as any);
+        return result
+          .then(() => {
+            return;
+          })
+          .then(() => instance as any);
       }
     }
 

packages/di/vitest.config.mts

@@ -10,12 +10,12 @@ export default defineConfig(
       coverage: {
         ...presets.test.coverage,
         thresholds: {
-          statements: 0,
-          branches: 0,
-          functions: 0,
-          lines: 0
+          statements: 98.92,
+          branches: 97.36,
+          functions: 99.08,
+          lines: 98.92
         }
       }
     }
   }
-);
+);

packages/engines/vitest.config.mts

@@ -10,12 +10,12 @@ export default defineConfig(
       coverage: {
         ...presets.test.coverage,
         thresholds: {
-          statements: 0,
-          branches: 0,
-          functions: 0,
-          lines: 0
+          statements: 81.55,
+          branches: 85.29,
+          functions: 78.4,
+          lines: 81.55
         }
       }
     }
   }
-);
+);

packages/graphql/apollo/vitest.config.mts

@@ -10,12 +10,12 @@ export default defineConfig(
       coverage: {
         ...presets.test.coverage,
         thresholds: {
-          statements: 0,
-          branches: 0,
-          functions: 0,
-          lines: 0
+          statements: 71.95,
+          branches: 74.07,
+          functions: 91.66,
+          lines: 71.95
         }
       }
     }
   }
-);
+);

packages/graphql/typegraphql/test/app/Server.ts

@@ -3,7 +3,8 @@ import {Configuration, Constant, Inject, PlatformApplication} from "@tsed/common
 import "@tsed/graphql-ws";
 import "@tsed/passport";
 import "@tsed/typegraphql";
-import * as fs from "fs";
+import * as fs from "node:fs";
+import {join} from "node:path";
 import {buildContext} from "graphql-passport";
 import {resolve} from "path";
 import {HelloController} from "./controllers/HelloController.js";
@@ -15,14 +16,14 @@ import "./services/RecipeService";
 import "./services/UsersRepository";
 
 const rootDir = __dirname; // automatically replaced by import.meta.dirname on build
-
+const rootCert = join(rootDir, "../..");
 @Configuration({
   rootDir,
   port: 8001,
   httpsPort: 8082,
   httpsOptions: {
-    key: fs.readFileSync("selfsigned.key"),
-    cert: fs.readFileSync("selfsigned.crt")
+    key: fs.readFileSync(join(rootCert, "selfsigned.key")),
+    cert: fs.readFileSync(join(rootCert, "selfsigned.crt"))
   },
   logger: {
     level: "info",

packages/graphql/typegraphql/test/graphql-passport.spec.ts

@@ -54,7 +54,7 @@ describe("GraphQL", () => {
             code: "INTERNAL_SERVER_ERROR",
             exception: {
               headers: {},
-              message: "Wrong credentials",
+              // message: "Wrong credentials",
               name: "UNAUTHORIZED",
               status: 401,
               type: "HTTP_EXCEPTION"

packages/graphql/typegraphql/vitest.config.mts

@@ -10,12 +10,12 @@ export default defineConfig(
       coverage: {
         ...presets.test.coverage,
         thresholds: {
-          statements: 0,
-          branches: 0,
-          functions: 0,
-          lines: 0
+          statements: 92.09,
+          branches: 61.11,
+          functions: 100,
+          lines: 92.09
         }
       }
     }
   }
-);
+);

packages/orm/adapters-redis/vitest.config.mts

@@ -10,12 +10,12 @@ export default defineConfig(
       coverage: {
         ...presets.test.coverage,
         thresholds: {
-          statements: 0,
-          branches: 0,
-          functions: 0,
-          lines: 0
+          statements: 99.62,
+          branches: 91.66,
+          functions: 100,
+          lines: 99.62
         }
       }
     }
   }
-);
+);

packages/orm/adapters/vitest.config.mts

@@ -10,12 +10,12 @@ export default defineConfig(
       coverage: {
         ...presets.test.coverage,
         thresholds: {
-          statements: 0,
-          branches: 0,
-          functions: 0,
-          lines: 0
+          statements: 100,
+          branches: 87.5,
+          functions: 100,
+          lines: 100
         }
       }
     }
   }
-);
+);

packages/orm/mikro-orm/vitest.config.mts

@@ -10,12 +10,12 @@ export default defineConfig(
       coverage: {
         ...presets.test.coverage,
         thresholds: {
-          statements: 0,
-          branches: 0,
-          functions: 0,
-          lines: 0
+          statements: 97.78,
+          branches: 85.05,
+          functions: 100,
+          lines: 97.78
         }
       }
     }
   }
-);
+);

packages/orm/mongoose/src/decorators/numberDecimal.spec.ts

@@ -137,7 +137,6 @@ describe("@NumberDecimal()", () => {
     const result = deserialize({}, {type: Model, additionalProperties: false});
 
     expect(result).toBeInstanceOf(Model);
-    expect(result).toHaveProperty("price");
     expect(result.price).toEqual(undefined);
   });
   it("should deserialize a number value using custom decimal", () => {

packages/orm/mongoose/vitest.config.mts

@@ -12,12 +12,12 @@ export default defineConfig(
       coverage: {
         ...presets.test.coverage,
         thresholds: {
-          statements: 0,
-          branches: 0,
-          functions: 0,
-          lines: 0
+          statements: 98.03,
+          branches: 95.02,
+          functions: 100,
+          lines: 98.03
         }
       }
     }
   }
-);
+);

packages/orm/objection/vitest.config.mts

@@ -10,12 +10,12 @@ export default defineConfig(
       coverage: {
         ...presets.test.coverage,
         thresholds: {
-          statements: 0,
-          branches: 0,
-          functions: 0,
-          lines: 0
+          statements: 94.37,
+          branches: 98.66,
+          functions: 92.3,
+          lines: 94.37
         }
       }
     }
   }
-);
+);

packages/orm/prisma/vitest.config.mts

@@ -10,12 +10,12 @@ export default defineConfig(
       coverage: {
         ...presets.test.coverage,
         thresholds: {
-          statements: 0,
-          branches: 0,
-          functions: 0,
-          lines: 0
+          statements: 90.48,
+          branches: 90.56,
+          functions: 92.85,
+          lines: 90.48
         }
       }
     }
   }
-);
+);

packages/orm/typeorm/vitest.config.mts

@@ -10,12 +10,12 @@ export default defineConfig(
       coverage: {
         ...presets.test.coverage,
         thresholds: {
-          statements: 0,
-          branches: 0,
-          functions: 0,
-          lines: 0
+          statements: 96.36,
+          branches: 86.95,
+          functions: 100,
+          lines: 96.36
         }
       }
     }
   }
-);
+);