fix(common): remove PlatformBuilder.addComponents() method which isn'…

…t used method BREAKING CHANGE: remove PlatformBuilder.addComponents() method which isn't used method
tsedio · Sep 8, 2024 · 5cd2e3c · 5cd2e3c
1 parent b905d78
commit 5cd2e3c
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 40 deletions.
diff --git a/packages/platform/common/src/builder/PlatformBuilder.spec.ts b/packages/platform/common/src/builder/PlatformBuilder.spec.ts
@@ -351,20 +351,6 @@ describe("PlatformBuilder", () => {
       expect(server.injector.get(Token)).toBeInstanceOf(Token);
     });
   });
-  describe("addComponents", () => {
-    it("should add components", async () => {
-      // GIVEN
-      const server = await PlatformCustom.bootstrap(ServerModule, {});
-
-      class MyClass {}
-
-      // WHEN
-      server.addComponents(MyClass);
-
-      // THEN
-      expect(server.injector.settings.get("imports")).toEqual([HealthModule, MyClass]);
-    });
-  });
   describe("addControllers", () => {
     it("should add controllers", async () => {
       // GIVEN

diff --git a/packages/platform/common/src/builder/PlatformBuilder.ts b/packages/platform/common/src/builder/PlatformBuilder.ts
@@ -141,16 +141,6 @@ export class PlatformBuilder<App = TsED.Application> {
     return !this.disableBootstrapLog && this.logger.info(...data, this.diff());
   }
 
-  /**
-   * Add classes to the components list
-   * @param classes
-   */
-  public addComponents(classes: Type | Type[]) {
-    this.settings.set("imports", this.settings.get<any[]>("imports", []).concat(classes));
-
-    return this;
-  }
-
   /**
    * Add classes decorated by @@Controller@@ to components container.
    *
@@ -172,7 +162,7 @@ export class PlatformBuilder<App = TsED.Application> {
    * @param {any[]} controllers
    */
   public addControllers(endpoint: string, controllers: TokenProvider | TokenProvider[]) {
-    [].concat(controllers).forEach((token) => {
+    [].concat(controllers as never[]).forEach((token: TokenProvider) => {
       this.settings.routes.push({token, route: endpoint});
     });
   }

diff --git a/packages/platform/common/src/utils/createHttpServer.spec.ts b/packages/platform/common/src/utils/createHttpServer.spec.ts
@@ -18,17 +18,17 @@ describe("createHttpServer", () => {
 
     expect(listener).toBeInstanceOf(Function);
 
-    const server = injector.get(Http.Server);
+    const server = injector.get(Http.Server)!;
 
     vi.spyOn(injector.logger, "info").mockReturnValue(undefined);
     vi.spyOn(injector.logger, "debug").mockReturnValue(undefined);
-    vi.spyOn(server, "listen").mockReturnValue(undefined);
-    vi.spyOn(server, "address").mockReturnValue({port: 8089, address: "0.0.0.0"});
-    vi.spyOn(server, "on").mockImplementation((event: string, cb: any) => {
+    vi.spyOn(server, "listen").mockReturnValue(undefined as never);
+    vi.spyOn(server, "address").mockReturnValue({port: 8089, address: "0.0.0.0"} as never);
+    vi.spyOn(server, "on").mockImplementation(((event: string, cb: any) => {
       if (event === "listening") {
         cb();
       }
-    });
+    }) as never);
 
     await listener();
 

diff --git a/packages/platform/common/src/utils/createHttpsServer.spec.ts b/packages/platform/common/src/utils/createHttpsServer.spec.ts
@@ -17,17 +17,17 @@ describe("createHttpsServer", () => {
     expect(!!injector.get(Https.Server)).toEqual(true);
     expect(listener).toBeInstanceOf(Function);
 
-    const server = injector.get(Https.Server);
+    const server = injector.get(Https.Server)!;
 
     vi.spyOn(injector.logger, "info").mockReturnValue(undefined);
     vi.spyOn(injector.logger, "debug").mockReturnValue(undefined);
-    vi.spyOn(server, "listen").mockReturnValue(undefined);
-    vi.spyOn(server, "address").mockReturnValue({port: 8089, address: "0.0.0.0"});
-    vi.spyOn(server, "on").mockImplementation((event: string, cb: any) => {
+    vi.spyOn(server, "listen").mockReturnValue(undefined as never);
+    vi.spyOn(server, "address").mockReturnValue({port: 8089, address: "0.0.0.0"} as never);
+    vi.spyOn(server, "on").mockImplementation(((event: string, cb: any) => {
       if (event === "listening") {
         cb();
       }
-    });
+    }) as never);
 
     await listener();
 

diff --git a/packages/platform/common/vitest.config.mts b/packages/platform/common/vitest.config.mts
@@ -10,12 +10,12 @@ export default defineConfig(
       coverage: {
         ...presets.test.coverage,
         thresholds: {
-          statements: 97.04,
-          branches: 90.76,
-          functions: 94.91,
-          lines: 97.04
+          statements: 97.03,
+          branches: 90.74,
+          functions: 94.89,
+          lines: 97.03
         }
       }
     }
   }
-);
+);