fix(oidc): change default OIDC path

BREAKING CHANGE: default value for `oidc.path` is `/oidc`
tsedio · Apr 15, 2022 · 50e5588 · 50e5588
1 parent a7806ae
commit 50e5588
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/packages/security/oidc-provider/.nycrc b/packages/security/oidc-provider/.nycrc
@@ -21,7 +21,7 @@
   ],
   "check-coverage": true,
   "statements": 99.67,
-  "branches": 77.78,
+  "branches": 77.36,
   "functions": 96.07,
   "lines": 99.65
 }
diff --git a/packages/security/oidc-provider/package.json b/packages/security/oidc-provider/package.json
@@ -35,7 +35,6 @@
     "jose2": "npm:jose@^2.0.4",
     "koa-mount": "^4.0.0",
     "koa-rewrite": "^3.0.1",
-    "lowdb": "3.0.0",
     "tslib": "2.3.1",
     "uuid": "8.3.2"
   },
@@ -47,6 +46,7 @@
     "@types/lowdb": "1.0.11",
     "@types/oidc-provider": "^7.1.1",
     "@types/uuid": "8.3.4",
+    "lowdb": "3.0.0",
     "oidc-provider": "7.10.6"
   },
   "peerDependencies": {
@@ -58,4 +58,4 @@
       "optional": false
     }
   }
-}
+}
diff --git a/packages/security/oidc-provider/src/OidcModule.ts b/packages/security/oidc-provider/src/OidcModule.ts
@@ -15,7 +15,7 @@ export class OidcModule {
   @Constant("PLATFORM_NAME")
   platformName: string;
 
-  @Constant("oidc.path", "/")
+  @Constant("oidc.path", "/oidc")
   basePath: string;
 
   @Inject()

diff --git a/packages/security/oidc-provider/test/oidc.integration.spec.ts b/packages/security/oidc-provider/test/oidc.integration.spec.ts
@@ -51,7 +51,7 @@ describe("OIDC", () => {
   it("should display the OIDC login page then login", async () => {
     const authRes = await request
       .get(
-        "/auth?client_id=client_id&response_type=id_token&scope=openid+email&nonce=foobar&prompt=login&redirect_uri=http://localhost:3000"
+        "/oidc/auth?client_id=client_id&response_type=id_token&scope=openid+email&nonce=foobar&prompt=login&redirect_uri=http://localhost:3000"
       )
       .set({
         Origin: "http://0.0.0.0:8081",
@@ -74,7 +74,7 @@ describe("OIDC", () => {
       })
       .send("email=test%40test.com&password=admin");
 
-    expect(postResponse.headers.location).to.equal(`http://0.0.0.0:8081/auth/${id}`);
+    expect(postResponse.headers.location).to.equal(`http://0.0.0.0:8081/oidc/auth/${id}`);
 
     const headers = {
       Origin: "http://0.0.0.0:8081",
@@ -106,7 +106,7 @@ describe("OIDC", () => {
       Origin: "http://0.0.0.0:8081",
       Host: "0.0.0.0:8081"
     });
-    expect(JSON.parse(res.text).authorization_endpoint).to.be.equal("http://0.0.0.0:8081/auth");
+    expect(JSON.parse(res.text).authorization_endpoint).to.be.equal("http://0.0.0.0:8081/oidc/auth");
   });
 });