Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pcb_keepout added #48

Merged
merged 5 commits into from
Sep 8, 2024
Merged

feat: pcb_keepout added #48

merged 5 commits into from
Sep 8, 2024

Conversation

imrishabh18
Copy link
Member

@imrishabh18 imrishabh18 commented Sep 6, 2024 •
edited
Loading

@tscircuitbot
Copy link
Contributor

tscircuitbot commented Sep 6, 2024 •
edited
Loading

Size Report

Bundle Size

  • Base branch size: 292K
  • PR branch size: 300K
  • Difference: +8

Install Size

  • Base branch size: 5.18mb
  • PR branch size: 5.26mb
  • Difference: +.08

Full Howfat Output (PR Branch)

@tscircuit/[email protected] (41 deps, 5.26mb, 660 files, ©undefined)
╭──────────────────────────────────────┬──────────────┬──────────┬───────┬───────────┬──────────────┬───────────╮
│ Name                                 │ Dependencies │     Size │ Files │ Native    │ License      │ Deprec    │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @lume/[email protected]                     │              │ 121.45kb │    31 │           │ BSD-3-Clause │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @tscircuit/[email protected] │              │ 114.74kb │    13 │           │              │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @tscircuit/[email protected]              │              │ 410.17kb │    28 │           │ ISC          │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @tscircuit/[email protected]          │           26 │   1.38mb │   234 │           │ ISC          │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @tscircuit/[email protected]               │           24 │   1.11mb │   203 │           │ ISC          │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected]                   │           25 │   1.31mb │   214 │           │ ISC          │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected]              │            5 │   1.07mb │    56 │           │ MIT          │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected]                         │            2 │ 331.04kb │    33 │           │ MIT          │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected]             │              │ 133.62kb │    37 │           │              │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected]         │              │ 430.45kb │    56 │           │ MIT          │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected]                           │              │ 651.16kb │    50 │           │ MIT          │           │
╰──────────────────────────────────────┴──────────────┴──────────┴───────┴───────────┴──────────────┴───────────╯

@imrishabh18 imrishabh18 requested a review from seveibar September 6, 2024 18:25
seveibar
seveibar requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but we should resolve the soup definition issues. IMO it is always worth having API repos like @tscircuit/soup and @tscircuit/props PRs reviewed because as soon as we realize something is wrong in the api design we generally shouldn't merge anything that uses the the deprecated api design (it gets really confusing to have old api versions/data hanging around- not worth it)

@imrishabh18 imrishabh18 requested a review from seveibar September 6, 2024 20:19
@imrishabh18
Copy link
Member Author

@seveibar For keepout the layer value can be both top and bottom, right?

@imrishabh18 imrishabh18 merged commit 1cd0587 into main Sep 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imrishabh18 @tscircuitbot @seveibar