-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cli #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the bun.lockb
is missing cause I can see you have added a new dependency
@imrishabh18 check if its good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kom-senapati can u add a video showing the command is generating the output.jsx file correctly.
cursorful-video-1737977667008.mp4 |
} | ||
export const Circuit = (props: Props) => { | ||
return ( | ||
<chip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seveibar Is this package circuit-json-to-tscircuit
only for Chip
components? As I can see if you pass a simple resistor as the circuit-json in this case, it still outputs a <Chip />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work for different types of components, not always chips
(may not work correctly currently)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current convertCircuitJsonToTscircuit
function is just having the <Chip />
template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks ok to me but let's get @imrishabh18 's approval before merging
@imrishabh18 the chip issue seems like a separate issue that we should file |
/claim #4
Closes #4