fix: fix wrong promise rejection on some fs methods with no return value #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs.promises.readFile triggers a list of different calls, the last one is "close". The "close" call has no return value, so we cannot check the existence of "val" to determine successfulness. closes #278
|
@tschaub I don't know how to write test case for this unhandled promise rejection. |
tschaub
approved these changes
Nov 3, 2019
|
Thanks @3cp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.promises.readFile triggers a list of different calls, the last one is "close". The "close" call has no return value, so we cannot check the existence of "val" to determine successfulness.
closes #278