Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbinding.readdir can take anywhere from 2 to 4 arguments #251

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

maxwellgerber
Copy link
Contributor

fixes #250

Does not provide support for DirEnt objects that were introduced in 10.10.0 with nodejs/node@c7944a7
But makes fs.readdir and fs.readdirSync work again.

@kibertoad
Copy link

@tschaub Could you please take a look at this and release a fixed version when possible? We are blocked by this...

@tschaub tschaub merged commit b81c39b into tschaub:master Sep 11, 2018
@tschaub
Copy link
Owner

tschaub commented Sep 11, 2018

Thanks @maxwellgerber!

@kibertoad
Copy link

@tschaub Any change you could release a new version with a fix :)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs.readdir seems broken since Node 10.10.0
3 participants