Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing test failures on node 8 #209

Merged
merged 3 commits into from
Jun 11, 2017
Merged

Fixing test failures on node 8 #209

merged 3 commits into from
Jun 11, 2017

Conversation

AGrzes
Copy link
Contributor

@AGrzes AGrzes commented Jun 5, 2017

This is still work in progress.

I managed to fix first issue - with stat function - but there is still a lot of tests failing.

@AGrzes AGrzes changed the title [WIP] Fixing test failures on node 8 [WIP] Fixing test failures on node 8 (#208) Jun 5, 2017
@AGrzes AGrzes changed the title [WIP] Fixing test failures on node 8 (#208) [WIP] Fixing test failures on node 8 Jun 5, 2017
@AGrzes
Copy link
Contributor Author

AGrzes commented Jun 5, 2017

At the moment 32 tests failed in comparison to initial 48.

@AGrzes AGrzes mentioned this pull request Jun 5, 2017
Closed
@AGrzes
Copy link
Contributor Author

AGrzes commented Jun 5, 2017

At the moment 32 tests failed in comparison to initial 48.

@AGrzes
Copy link
Contributor Author

AGrzes commented Jun 6, 2017

All test failures resolved.
I still do not like the fact that maybeStatCallback is copy-paste of maybeCallback

@AGrzes AGrzes changed the title [WIP] Fixing test failures on node 8 Fixing test failures on node 8 Jun 6, 2017
@tschaub
Copy link
Owner

tschaub commented Jun 11, 2017

Thanks for the work on this @AGrzes!

@tschaub tschaub merged commit 86e9b1b into tschaub:master Jun 11, 2017
@tschaub
Copy link
Owner

tschaub commented Jun 11, 2017 •
edited
Loading

I still do not like the fact that maybeStatCallback is copy-paste of maybeCallback

I removed the duplication in 85396c2 (by adding a wrapStatsCallback function).

@tschaub tschaub mentioned this pull request Jun 11, 2017
Merged
@tschaub
Copy link
Owner

tschaub commented Jun 11, 2017

Support for Node 8 published in [email protected]. Thanks @AGrzes for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AGrzes @tschaub