Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please consider upgrading to q-io@2 #61

Closed
gordonwoodhull opened this issue May 23, 2016 · 1 comment
Closed

please consider upgrading to q-io@2 #61

gordonwoodhull opened this issue May 23, 2016 · 1 comment

Comments

@gordonwoodhull
Copy link

Please excuse my inexperience with npm dependencies; I may be overlooking a simple solution here.

I've been tracking down a crash in the dc.js docs build: dc-js/dc.js#1142

I filed an issue on grunt-jsdoc-to-markdown: jsdoc2md/grunt-jsdoc-to-markdown#8

The issue wasn't there, but @75lb was kind enough to track down the problem to montage/collections overriding Array.prototype.find wrong, which can break any other grunt modules at random: montagejs/collections#139

montage/collections is included in grunt-gh-pages via q-io.

In this issue @kriskowal notes that q-io@2 uses collections@2, which does not have this problem: kriskowal/q-io#131

I have not done extensive testing, but installing q-io@2 into node_modules/grunt-gh-pages fixes my build and grunt-gh-pages seems happy with it.

gordonwoodhull added a commit to dc-js/dc.js that referenced this issue May 23, 2016
@gordonwoodhull
Copy link
Author

Thanks for merging #62, @tschaub!

I've verified this fixes the build problems we were having.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant