Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Button in OrganizersView #3

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Use Button in OrganizersView #3

merged 2 commits into from
Mar 12, 2024

Conversation

yutailang0119
Copy link
Contributor

@yutailang0119 yutailang0119 commented Mar 12, 2024 •
edited
Loading

onTapGesture seems to have a narrow selectable area.
Button is standard, but text color is primary.

If text color back, foregroundColor(_:) works, but this is deprecated.
foregroundStyle(_:) is not work.

d-date
d-date approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@d-date d-date left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@d-date d-date merged commit 38d9717 into tryswift:main Mar 12, 2024
@d-date d-date deleted the organizers/list-tap branch March 12, 2024 14:37
naoki-mrmt added a commit that referenced this pull request Mar 12, 2024
@naoki-mrmt
Merge branch 'main' into feature/naoki-mrmt
68a3675 
* main:
  Fix usagimaru SNS link (#6)
  Fix onTapGesture to Button in OrganizersView (#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-date d-date d-date approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yutailang0119 @d-date