Added labels to the drawing functions #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are some examples of how it looks when drawing bounding boxes:
|
joaqo
suggested changes
Mar 9, 2022
norfair/drawing.py
Outdated
| label_draw_position -= radius | ||
| cv2.putText( | ||
| frame, | ||
| f"Label: {d.label}", |
There was a problem hiding this comment.
"Label" string may occupy too much space when there are many objects on the image, it may make sense to make it shorter, or optional.
norfair/drawing.py
Outdated
| ) | ||
| ] | ||
| if draw_labels: | ||
| lines_to_draw.append("label:{}".format(obj.label)) |
There was a problem hiding this comment.
Probably better to abbreviate 'label', as it takes too much space on the image.
facundo-lezama
force-pushed
the
drawing-with-labels
branch
3 times, most recently
from
fd74de3
to
a070221
Compare
joaqo
reviewed
Mar 11, 2022
norfair/drawing.py
Outdated
Comment on lines
22
to
23
| color_by_label: Optional[bool] = False, | ||
| draw_labels: Optional[bool] = False, |
There was a problem hiding this comment.
These don't need to be optional, as optional would effectively let this variable have 3 states (true, false, None) but we only need 2.
norfair/drawing.py
Outdated
Comment on lines
74
to
75
| color_by_label: Optional[bool] = False, | ||
| draw_labels: Optional[bool] = False, |
norfair/drawing.py
Outdated
Comment on lines
152
to
153
| color_by_label: Optional[bool] = False, | ||
| draw_labels: Optional[bool] = False, |
facundo-lezama
force-pushed
the
drawing-with-labels
branch
from
a070221
to
534434b
Compare
javiber
pushed a commit
that referenced
this pull request
Sep 13, 2022
Added labels to the drawing functions
javiber
pushed a commit
that referenced
this pull request
Sep 13, 2022
Added labels to the drawing functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Norfair allows to track multiple objects from different classes within a single
Trackerobject, the modifications added in this PR make it possible to draw labels both on detections and tracked objects. It also adds the possibility to color points and bounding boxes based on the labels so that objects from the same class have the same color.Changes were made so that we keep backwards compatibility.