Bug fix in index for prediction score in YOLOv5 demo #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fcakyon! I have tested it and it looks good. This time we are covered (I see that before, we were using the class as the threshold because of the bug), but for next time, a bit more detail will come handy:
With that said, I will merge this now. |
dekked
changed the title
|
Hi @dekked ! Yes we were accidentally using category id as prediction score. Since the category ids of car and pedestrian are larger than 1 we didnt face any issues beforehand. Today I was dealing with objects having category id 0 and realized the typo. After debugging it i found the issue was caused by indexing error :) |
javiber
pushed a commit
that referenced
this pull request
Sep 13, 2022
javiber
pushed a commit
that referenced
this pull request
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a minor typo in yolov5 demo