Small refactor to metrics

[aguscas]

No description provided.

[joaqo]

Some small changes needed.

[joaqo]

This empty line shouldn't be here.

[joaqo]

Add a catch to the exception that will get raised if we don't find the variable_name with a descriptive error message. As it is currently I think we'll raise a generic index error as the line variable will eventually be out of bounds of we don't find the variable_name.

[joaqo]

I would actually write this class like this:

  class InformationFile:
      def __init__(self, file_path):
          self.path = file_path
          with open(file_path, "r") as myfile:
              self.file = myfile.read()
          self.lines = self.file.splitlines()

      def search(self, variable_name):
          for line in self.lines:
              if line[: len(variable_name)] == variable_name:
                  result = line[len(variable_name) + 1 :]
                  break
          else:
              raise ValueError(f"Couldn't find '{variable_name}' in {self.path}")
          if result.isdigit():
              return int(result)
          else:
              return result

Please contact me when you reach this comment as there are several very cool python things to talk about regarding this. Just as a remind for myself those things are (Exception vs if, for else statements, string's index method and fstrings).

[joaqo]

This is great, two small changes and its ready for merging!

[joaqo]

Python code style states that objects should be named using 'lower_case_with_underscores' and classes should be named using 'CamelCase'. Also, it is better to use more descriptive names, unless they are way too long, which is not the case here.

Therefore, if I am understanding what these variables are correctly, I would rename them to self.image_extension and self.image_directory.

[joaqo]

self.file is only used here, so we can remove it from self and just name it file.

[joaqo]

Perfect, thanks!