Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reid_hit_counter initialization. #224

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Conversation

facundo-lezama
Copy link
Collaborator

@facundo-lezama facundo-lezama commented Dec 6, 2022

Fix a bug with the initialization of reid_hit_counter that started decreasing when hit_counter > 0 and made objects die before expected. Also added unit tests for ReID.

Pending:

  • test edge cases
  • write PR description

@facundo-lezama facundo-lezama marked this pull request as ready for review December 7, 2022 15:09
Copy link
Member

@JuanFKurucz JuanFKurucz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working, nice catch! Maybe it's a good idea to update the generated video in the ReId demo.

@facundo-lezama facundo-lezama merged commit 1cdec7b into master Dec 7, 2022
@facundo-lezama facundo-lezama deleted the fix-reid-hit-counter branch December 7, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"reid_hit_counter" Keeps Decreasing Causing Long-living Objects To Killed Suddenly
2 participants