-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add small object tracking demo using SAHI #188
Conversation
ab33675
to
fadd361
Compare
fadd361
to
e1334bb
Compare
@fcakyon maybe you have any comments or suggestions here :) |
demos/sahi/src/utils.py
Outdated
default=True, | ||
) | ||
parser.add_argument( | ||
"--slice-height", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep things simpler, we can use just one --slice-size
argument instead of two --slice-height
and --slice-width
and set both slice_height
and slice_width
as slice_size
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an excellent suggestion. Thanks! I tackled it in the new commit
demos/sahi/src/utils.py
Outdated
default=0.2, | ||
) | ||
parser.add_argument( | ||
"--overlap-width-ratio", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep things simpler, we can use just one --overlap-ratio
argument instead of two --overlap-width-ratio
and --overlap-height-ratio
and set both overlap_width_ratio
and overlap_height_ratio
as overlap_ratio
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this suggestion too, I tackled it to make everything simpler!
Wow @JuanFKurucz, thanks for this awesome demo! @dekked added some comments. In overall, it looks good 💯 |
demos/sahi/requirements.txt
Outdated
@@ -0,0 +1,3 @@ | |||
opencv-python==4.2.0.32 | |||
sahi==0.10.5 | |||
yolov5==6.1.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets use the latest yolov5 and sahi versions :)
yolov5==6.1.8 | |
yolov5==6.2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
demos/sahi/requirements.txt
Outdated
@@ -0,0 +1,3 @@ | |||
opencv-python==4.2.0.32 | |||
sahi==0.10.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets use the latest yolov5 and sahi versions :)
sahi==0.10.5 | |
sahi==0.10.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I have updated it and recreated the demo video just in case!
demos/sahi/README.md
Outdated
# SAHI: Slicing Aided Hyper Inference Demo | ||
|
||
An example of how to use Norfair along with [SAHI: Slicing Aided Hyper Inference](https://github.com/obss/sahi) | ||
to perform detection and tracking on small objects using YOLOv5x as the detector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to perform detection and tracking on small objects using YOLOv5x as the detector. | |
to perform detection and tracking on small objects using [YOLOv5x](https://github.com/ultralytics/yolov5) as the detector. |
c228a6f
to
0d966a0
Compare
This PR implements a demo using SAHI: Slicing Aided Hyper Inference to be able to track small objects in a video.