Add official demo in Google Colab #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoFernandezC
force-pushed
the
chore/colab-demo
branch
from
73dd2c9 to
0be1e0a
Compare
javiber
requested changes
Sep 20, 2022
demos/colab/demo.py
Outdated
| import tempfile | ||
|
|
||
| import numpy as np | ||
| from distance_function import euclidean_distance, iou |
There was a problem hiding this comment.
this module is available under norfair.distances no need to repeat it in the demo
There was a problem hiding this comment.
but be careful with the distance threshold for iou, the implementation provided by norfair is bound to [0,1] where 1 means that the boxes don't touch and 0 means the boxes are the same
There was a problem hiding this comment.
I changed these distance functions to create_normalized_mean_euclidean_distance like you suggest me on the HF demo.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
DiegoFernandezC
force-pushed
the
chore/colab-demo
branch
2 times, most recently
from
903445a to
d351b6e
Compare
DiegoFernandezC
force-pushed
the
chore/colab-demo
branch
from
d351b6e to
03a2ec6
Compare
DiegoFernandezC
force-pushed
the
chore/colab-demo
branch
from
03a2ec6 to
9b78518
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a Colab demo similar to the demo running on the Hugging Face Spaces.
When this PR is approved I change the GitHub links to the master brach.