Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blackify the whole repo #141

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Blackify the whole repo #141

merged 3 commits into from
Sep 5, 2022

Conversation

javiber
Copy link
Collaborator

@javiber javiber commented Aug 10, 2022

Ran Black on the entire repo and added a GA to enforce it on new PRs.

We probably want to merge existing PRs first

Questions:

  • should we enforce isort?
  • should we enforce pylint? if we do, we should only enforce it on norfair/ because doing it on demos/ will raise all sorts of dependencies errors. We should also discuss if we only want to check some warnings

Left the code necessary to enforce them on the GA but it's commented out

@javiber javiber mentioned this pull request Aug 26, 2022
3 tasks
@javiber javiber marked this pull request as ready for review September 5, 2022 17:44
@javiber javiber linked an issue Sep 5, 2022 that may be closed by this pull request
@javiber javiber merged commit 661d0c0 into master Sep 5, 2022
@javiber javiber deleted the black branch September 5, 2022 19:54
javiber added a commit that referenced this pull request Sep 13, 2022
javiber added a commit that referenced this pull request Sep 13, 2022
@javiber javiber restored the black branch September 13, 2022 20:30
@javiber javiber deleted the black branch September 13, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run black and make it compulsory for PRs
1 participant