Add 'No filter' and 'Optimized KF' setups #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aguscas
force-pushed
the
optimized-kalman-filter
branch
2 times, most recently
from
6f832c0
to
3b4174c
Compare
added 4 commits
April 28, 2022 12:48
aguscas
force-pushed
the
optimized-kalman-filter
branch
from
b77d73b
to
fb9a534
Compare
aguscas
force-pushed
the
optimized-kalman-filter
branch
from
1752007
to
2ace293
Compare
joaqo
reviewed
May 18, 2022
There was a problem hiding this comment.
This is great! I am thinking we should probably change the filter setup classes' names to 'filter factory', as it more accurately represents what they do, and why they need to have separate classes. Also we should probably rename the old FilterSetup to something like FilterPyKalmanFilterFactory. We can discuss this whenever you have time.
aguscas
force-pushed
the
optimized-kalman-filter
branch
from
fd07f05
to
8bb407d
Compare
It seems the new optimized filter is a tiny bit less accurate, so we are regressing this until we find out why. They should be identically accurate in theory.
joaqo
force-pushed
the
optimized-kalman-filter
branch
from
aa87667
to
e956d2e
Compare
javiber
pushed a commit
that referenced
this pull request
Sep 13, 2022
Add 'No filter' and 'Optimized KF' setups
javiber
pushed a commit
that referenced
this pull request
Sep 13, 2022
Add 'No filter' and 'Optimized KF' setups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.