Hover over stops - faster #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exxonvaldez
reviewed
Nov 16, 2019
frontend/src/components/MapStops.jsx
Outdated
| @@ -85,7 +85,7 @@ class MapStops extends Component { | |||
| // svg "v" shape rotated by the given rotation value. | |||
|
|
|||
| icon = L.divIcon({ | |||
| className: 'custom-icon', // this is needed to turn off the default icon styling (blank square) | |||
| className: `custom-icon id${stop.sid}`, // this is needed to turn off the default icon styling (blank square) | |||
There was a problem hiding this comment.
custom-icon was just a dummy class (that's what the comment was about)... can you try removing it?
exxonvaldez
approved these changes
Nov 16, 2019
| @@ -132,6 +133,23 @@ function ControlPanel(props) { | |||
| }); | |||
| } | |||
|
|
|||
| function handleMouseOver(node, title) { | |||
There was a problem hiding this comment.
Could use jsdoc comments here to explain these methods since the names are fairly generic. Also could consider renaming the methods to be more specific (handleItemMouseOut, handleSelectClose).
|
Nice, so let's remember to close #362 when this one gets merged. |
|
@zachzwy , go ahead and merge this whenever you can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272. Improves PR #362.
Use a different approach to create "hover over stops" effect. Instead of letting React rerender the whole routes (see PR #362 for detailed performance issue), it adds an "on-hover" className to the stop that being hovered. The "on-hover" class uses a pseudo class .on-hover::before to add stop title.
Proposed changes
When you hover over entries in the To & From Dropdowns, the stop/route on the map will update correspondingly. So you know exactly where the stop you're hovering is on the map.
Link to demo, if any
https://open-transit.herokuapp.com/route/M/direction/M____O_D00/fromStop/6996/toStop/7125