Skip to content

Commit

Permalink
Always use a static gtest and gbench (rapidsai#2265)
Browse files Browse the repository at this point in the history
Removes the need for us to install GTest or GBench in our raft testing CI

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Jake Awe (https://github.com/AyodeAwe)

URL: rapidsai#2265
  • Loading branch information
robertmaynard authored Apr 16, 2024
1 parent e977d2e commit 39f3854
Show file tree
Hide file tree
Showing 10 changed files with 3 additions and 49 deletions.
2 changes: 0 additions & 2 deletions conda/environments/all_cuda-118_arch-aarch64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ dependencies:
- dask-cuda==24.6.*
- doxygen>=1.8.20
- gcc_linux-aarch64=11.*
- gmock>=1.13.0
- graphviz
- gtest>=1.13.0
- ipython
- joblib>=0.11
- libcublas-dev=11.11.3.6
Expand Down
2 changes: 0 additions & 2 deletions conda/environments/all_cuda-118_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ dependencies:
- dask-cuda==24.6.*
- doxygen>=1.8.20
- gcc_linux-64=11.*
- gmock>=1.13.0
- graphviz
- gtest>=1.13.0
- ipython
- joblib>=0.11
- libcublas-dev=11.11.3.6
Expand Down
2 changes: 0 additions & 2 deletions conda/environments/all_cuda-122_arch-aarch64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ dependencies:
- dask-cuda==24.6.*
- doxygen>=1.8.20
- gcc_linux-aarch64=11.*
- gmock>=1.13.0
- graphviz
- gtest>=1.13.0
- ipython
- joblib>=0.11
- libcublas-dev
Expand Down
2 changes: 0 additions & 2 deletions conda/environments/all_cuda-122_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ dependencies:
- dask-cuda==24.6.*
- doxygen>=1.8.20
- gcc_linux-64=11.*
- gmock>=1.13.0
- graphviz
- gtest>=1.13.0
- ipython
- joblib>=0.11
- libcublas-dev
Expand Down
6 changes: 0 additions & 6 deletions conda/recipes/libraft/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,6 @@ cmake_version:
nccl_version:
- ">=2.9.9"

gbench_version:
- "==1.8.0"

gtest_version:
- ">=1.13.0"

glog_version:
- ">=0.6.0"

Expand Down
6 changes: 0 additions & 6 deletions conda/recipes/libraft/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -304,9 +304,6 @@ outputs:
- libcusolver-dev
- libcusparse-dev
{% endif %}
- benchmark {{ gbench_version }}
- gmock {{ gtest_version }}
- gtest {{ gtest_version }}
run:
- {{ pin_compatible('cuda-version', max_pin='x', min_pin='x') }}
{% if cuda_major == "11" %}
Expand All @@ -319,9 +316,6 @@ outputs:
- libcusparse
{% endif %}
- {{ pin_subpackage('libraft', exact=True) }}
- benchmark {{ gbench_version }}
- gmock {{ gtest_version }}
- gtest {{ gtest_version }}
about:
home: https://rapids.ai/
license: Apache-2.0
Expand Down
3 changes: 0 additions & 3 deletions conda/recipes/raft-ann-bench/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ cmake_version:
nccl_version:
- ">=2.9.9"

gtest_version:
- ">=1.13.0"

glog_version:
- ">=0.6.0"

Expand Down
5 changes: 3 additions & 2 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -185,12 +185,13 @@ if(NOT BUILD_CPU_ONLY)
endif()

if(BUILD_TESTS)
include(cmake/thirdparty/get_gtest.cmake)
include(${rapids-cmake-dir}/cpm/gtest.cmake)
rapids_cpm_gtest(BUILD_STATIC)
endif()

if(BUILD_PRIMS_BENCH OR BUILD_ANN_BENCH)
include(${rapids-cmake-dir}/cpm/gbench.cmake)
rapids_cpm_gbench()
rapids_cpm_gbench(BUILD_STATIC)
endif()

if(BUILD_CAGRA_HNSWLIB)
Expand Down
22 changes: 0 additions & 22 deletions cpp/cmake/thirdparty/get_gtest.cmake

This file was deleted.

2 changes: 0 additions & 2 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,6 @@ dependencies:
- output_types: [conda]
packages:
- *cmake_ver
- gtest>=1.13.0
- gmock>=1.13.0
docs:
common:
- output_types: [conda]
Expand Down

0 comments on commit 39f3854

Please sign in to comment.