This repository has been archived by the owner on Apr 21, 2020. It is now read-only.
Contract creation #216
Merged
Contract creation #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 10, 2018 19:35
Otherways alert when define object with key = null for the test https://web3js.readthedocs.io/en/1.0/web3-eth.html?highlight=block#id50
vikmeup
reviewed
Mar 11, 2018
| @@ -58,7 +58,7 @@ export interface ITransaction { | |||
| blockHash: string | null, | |||
| blockNumber: number, | |||
| from: string, | |||
| gas: string, | |||
| gas: number, | |||
There was a problem hiding this comment.
Does this changes return value?
There was a problem hiding this comment.
Initial gas type was defined wrong. It does not return value, it used as an interface.
| const from = String(transaction.from).toLowerCase(); | ||
| const to = String(transaction.to).toLowerCase(); | ||
| const to: string = transaction.to === null ? "" : String(transaction.to).toLowerCase(); | ||
| const addresses: string[] = to ? [from, to] : [from]; |
There was a problem hiding this comment.
if to == null, then contract should exist and you need to save contract address
There was a problem hiding this comment.
Not at this point, later in the code.
There was a problem hiding this comment.
let's do it now, that's the whole point of this change
| const from = String(transaction.from).toLowerCase(); | ||
| const to = String(transaction.to).toLowerCase(); | ||
| const to: string = transaction.to === null ? "" : String(transaction.to).toLowerCase(); | ||
| const addresses: string[] = to ? [from, to] : [from]; |
There was a problem hiding this comment.
can you do flatMap instead? [from, to].flatMap() - it will remove null
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.