Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [sc-29879] Update MATIC -> POL, Klayth -> Kaia #176

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

tw-daniel
Copy link
Contributor

@tw-daniel tw-daniel commented Sep 26, 2024

Story details: https://app.shortcut.com/trust-wallet-1/story/29879

  1. Polygon chain migrated from MATIC symbol to POL. So we need to do migration in our services as well.
  2. Klayth did rebranding, so we need to update the name, explorer and type.

Copy link
Contributor

@nikoskarakostas nikoskarakostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also raised in DM, just checking here as well. Are we positive we don't also want to change the POL name too? Concern is coming from trustwallet/assets@cadeaeb where we changed the name as well.

iCell
iCell previously approved these changes Sep 27, 2024
types/token.go Show resolved Hide resolved
@nikoskarakostas
Copy link
Contributor

also raised in DM, just checking here as well. Are we positive we don't also want to change the POL name too? Concern is coming from trustwallet/assets@cadeaeb where we changed the name as well.

To be clear here, I mean we only updated the Symbol on this PR, but the name remains as "Polygon", in the assets-repo PR we updated both.

@tw-daniel tw-daniel merged commit ee6082f into master Sep 30, 2024
2 checks passed
@tw-daniel tw-daniel deleted the sc-29879 branch September 30, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants