Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TC-1593 CycloneDX SBOM package to Product relationship is missing #82

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

mrizzi
Copy link
Collaborator

@mrizzi mrizzi commented Jun 25, 2024

Description of the PR

  • the bug was with skipping adding metadata when dealing with the top level package (i.e. if reflect.DeepEqual(currPkg, toplevel) { continue } because only IsDependency predicates shouldn't be added because already added in
    preds.IsDependency = append(preds.IsDependency, common.CreateTopLevelIsDeps(toplevel[0], c.packagePackages, nil, "top-level package GUAC heuristic connecting to each file/package")...)
  • added integration test for checking:
    • ALL the expected metadata have been ingested
    • findDependentProduct works for the log4j package reported in TC-1593

Fixes https://issues.redhat.com/browse/TC-1593

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@mrizzi mrizzi requested a review from dejanb June 25, 2024 14:38
@mrizzi mrizzi merged commit dbaaba0 into trustification:trustification-main Jun 25, 2024
1 check passed
@mrizzi mrizzi deleted the TC-1593 branch June 25, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants