-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onlykey-agent crashes on mac #38
Comments
I also experience this issue and have been ignoring it for a while. I will investigate, and would love it if someone has a hunch of where to look. |
For reference, here is what I see in my own "Crash Report" from the Console app: Translated Report (Full Report Below)
|
I looked at this for a bit tonight and I don't see an obvious solution. It seems benign, but in case this might help someone else fix it (or point me in the right direction to fix it): Based on the call stack that I experience (I posted above) the error happens after successful usage of onlykey, and it appears to be called from the finalizer in NOTE: More on The finalizer calls in the underlying NOTE: |
@activescott thanks for taking a look! Do you have any workaround to prevent macos from opening the crash report modal window? |
Might be an issue with cython-hidapi I am open to ideas to try here. I might be able to try a delay before closing and see if that affects this https://github.com/onlykey/lib-agent/blob/da6461a6eb4b97fc306f975019c8a83ef47c90a5/libagent/device/onlykey.py#L137 |
@cizmazia I'm sorry I don't. I'd like to see this fixed at the source rather than hide it so I'm going to let it annoy me in hopes it will provoke me enough to dig in again sometime 🙃 |
@onlykey I also suspect cython-hidap I'm also open to ideas - since I couldn't put my finger on the root cause here. I will hack my local instance of libagent there and see if it gets rid of the issue for me. I'll post back with what I see |
still seeing the crash when adding a |
Similar issue here, the partial solution mentioned is to use docker - https://onlykey.discourse.group/t/onlykey-agent-macos-illegal-instruction/833/9 |
@cizmazia Thanks, yes it looks like its a problem with hidapi on certain Mac versions. @activescott Can you verify that using hidapi 0.10.1 fixes this issue for you? |
|
Yep that fixes it for me! 🥳 I normally use homebrew-installed version so I switched to pip momentarily to verify this. I'm not exactly sure how to update the homebrew formula to pin an old version of hidapi but I'll try to find time to look into it and see if its an easy fix. |
Fixed by trezor/cython-hidapi#150 |
This seems to be fixed in cython-hidapi 0.14.0 but I still experience the issue with hidapi |
When I run git pull with onlykey-agent, it works as expected except that macOS always opens a modal window "Python quit unexpectedly" with the crash report below.
Command:
Crash Report (click to expand)
The text was updated successfully, but these errors were encountered: