fix: issuer test suites (#1818)

* fix: issuer test suites * fix: lint
trustbloc · Dec 8, 2024 · 6404fa4 · 6404fa4
1 parent f069bbd
commit 6404fa4
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 8 deletions.
diff --git a/pkg/restapi/v1/issuer/controller.go b/pkg/restapi/v1/issuer/controller.go
@@ -256,13 +256,24 @@ func (c *Controller) ValidateRawCredential(
 		}
 	}
 
-	credSubjectKind := reflect.TypeOf(finalCredentials["credentialSubject"]).Kind()
+	credSubObj, credSubObjOk := finalCredentials["credentialSubject"]
+	if !credSubObjOk || credSubObj == nil {
+		return resterr.NewValidationError(resterr.InvalidValue, "credential_subject",
+			errors.New("credential_subject must be specified"))
+	}
+
+	credSubjectKind := reflect.TypeOf(credSubObj).Kind()
 	if credSubjectKind != reflect.Map && credSubjectKind != reflect.Array && credSubjectKind != reflect.Slice {
 		return resterr.NewValidationError(resterr.InvalidValue, "credential_subject",
 			errors.New("credential_subject must be an object or an array of objects"))
 	}
 
-	if subjects, subjectsOk := finalCredentials["credentialSubject"].([]interface{}); subjectsOk {
+	if subjects, subjectsOk := credSubObj.([]interface{}); subjectsOk {
+		if len(subjects) == 0 {
+			return resterr.NewValidationError(resterr.InvalidValue, "credential_subject",
+				errors.New("credential_subject must have at least one subject"))
+		}
+
 		for _, subject := range subjects {
 			if mappedSubject, ok := subject.(map[string]interface{}); !ok || len(mappedSubject) == 0 {
 				return resterr.NewValidationError(resterr.InvalidValue, "credential_subject",
@@ -330,12 +341,11 @@ func (c *Controller) issueCredential(
 		return nil, err
 	}
 
-	// not sure why we need this, but this breaks vc-data-model-2.0-test-suite
-	// issuer := credentialParsed.Contents().Issuer
-	// if issuer != nil && !strings.HasPrefix(issuer.ID, "did:") {
-	//	return nil, resterr.NewValidationError(resterr.InvalidValue, "credential.issuer",
-	//		errors.New("issuer must be a DID"))
-	//}
+	issuer := credentialParsed.Contents().Issuer
+	if issuer != nil && !strings.HasPrefix(issuer.ID, "did:") {
+		return nil, resterr.NewValidationError(resterr.InvalidValue, "credential.issuer",
+			errors.New("issuer must be a DID"))
+	}
 
 	// maybe implement some better handling https://www.w3.org/TR/vc-data-model-2.0/#dfn-url
 	if strings.Contains(credentialParsed.Contents().ID, " ") {

diff --git a/pkg/restapi/v1/issuer/controller_test.go b/pkg/restapi/v1/issuer/controller_test.go
@@ -3399,6 +3399,14 @@ func TestValidateRawCredential(t *testing.T) {
 		}, &profileapi.Issuer{}), "credential_subject must be an object or an array of objects")
 	})
 
+	t.Run("validate credentialSubject exists", func(t *testing.T) {
+		assert.ErrorContains(t, c.ValidateRawCredential(map[string]any{
+			"@context": []any{
+				"https://www.w3.org/ns/credentials/v2",
+			},
+		}, &profileapi.Issuer{}), "credential_subject must be specified")
+	})
+
 	t.Run("validate credentialSubject properties", func(t *testing.T) {
 		assert.ErrorContains(t, c.ValidateRawCredential(map[string]any{
 			"@context": []interface{}{
@@ -3409,6 +3417,15 @@ func TestValidateRawCredential(t *testing.T) {
 			},
 		}, &profileapi.Issuer{}), "each credential_subject must have properties")
 	})
+
+	t.Run("validate credentialSubject at least one subject", func(t *testing.T) {
+		assert.ErrorContains(t, c.ValidateRawCredential(map[string]any{
+			"@context": []interface{}{
+				"https://www.w3.org/ns/credentials/v2",
+			},
+			"credentialSubject": []any{},
+		}, &profileapi.Issuer{}), "must have at least one subject")
+	})
 }
 
 func TestValidateRelatedResources(t *testing.T) {