Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add data-wasm-opt-params #901

Merged
merged 1 commit into from
Nov 5, 2024
Merged

feat: add data-wasm-opt-params #901

merged 1 commit into from
Nov 5, 2024

Conversation

maratik123
Copy link
Contributor

This fixes #900

@ctron
Copy link
Collaborator

ctron commented Oct 31, 2024

Thanks for the change. It looks good. I'd prefer to have the value stored as Vec<String> though. And do the parsing when retrieving this from the attribute.

@ctron ctron added the enhancement New feature or request label Oct 31, 2024
@maratik123
Copy link
Contributor Author

@ctron Done, but the code become more cumbersome

@ctron
Copy link
Collaborator

ctron commented Oct 31, 2024

I'd kept the original let mut args: Vec<&str> = vec![&arg_output, &arg_opt_level, &target_wasm]; … but it works the same way.

@ctron ctron enabled auto-merge November 5, 2024 09:38
@ctron ctron added this pull request to the merge queue Nov 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 5, 2024
@ctron ctron added this pull request to the merge queue Nov 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 5, 2024
@ctron
Copy link
Collaborator

ctron commented Nov 5, 2024

@maratik123 could you rebase and maybe squash the commits?

@maratik123
Copy link
Contributor Author

Rebased and squashed

@ctron ctron added this pull request to the merge queue Nov 5, 2024
Merged via the queue into trunk-rs:main with commit ce872ce Nov 5, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for customizing wasm-opt options
2 participants