Move api-client out of the cli #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😎 Merged successfully - details. |
gnalh
force-pushed
the
gabe/move-api-client
branch
from
f2a0ffa to
861a144
Compare
gnalh
commented
Jan 17, 2025
| @@ -74,7 +74,7 @@ where | |||
| } | |||
| }); | |||
|
|
|||
| let result = Retry::spawn(default_delay(), || (&mut self.action).run()).await; | |||
| let result = Retry::spawn(default_delay(), || self.action.run()).await; | |||
gnalh
commented
Jan 17, 2025
Comment on lines
-332
to
+344
| .cloned() | ||
| .take(2) | ||
| .cloned() |
There was a problem hiding this comment.
This was also changed by clippy.
gnalh
force-pushed
the
gabe/move-api-client
branch
3 times, most recently
from
d939ee6 to
3b25066
Compare
dfrankland
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Oh! I just figured out that this is the config to make imports get auto-formatted!
https://rust-lang.github.io/rustfmt/?version=v1.8.0&search=#group_imports
gnalh
force-pushed
the
gabe/move-api-client
branch
from
8dc867c to
19819f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to remove having
libsunder the cli, separate this out into the api crate. This PR also cleans up some of the naming and adds corresponding request / response types where previously missing.